Page MenuHomePhabricator

Create an icon for TemplateWizard
Closed, ResolvedPublic

Description

Let's go with the puzzle piece that VE has for now. We can reconsider if we hear feedback about it being confusing.

Related Objects

Event Timeline

Change 420632 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/TemplateWizard@master] Switch to use the OOUI puzzle icon

https://gerrit.wikimedia.org/r/420632

Samwilson edited projects, added Community-Tech-Sprint; removed Community-Tech.
Samwilson added a subscriber: Samwilson.

The above patch just uses the existing puzzle.png file, but perhaps it could be made to look nicer and more like the other WikiEditor icons.

Esanders renamed this task from Create a logo for TemplateWizard to Create an icon for TemplateWizard .Mar 20 2018, 1:05 PM

Why does the icon appear to have extraneous space to the right?
See

image.png (99×626 px, 26 KB)
and
image.png (88×584 px, 19 KB)

The space is what appears between button groups and is normally filled with a vertical bar, but because the insert group is next to the tabs that bar is removed. With no extra things turned on, the toolbar looks like this (with boxes added to buttons and groups):

Screenshot-2018-3-21 Editing Main Page - Dev Wiki wiki1.png (59×615 px, 6 KB)

The border-right of the insert group is removed by WikiEditor.

So I think the problem is that CodeMirror adds itself to it's own new codemirror group and that appears after the insert group, and so the dividing bar is not there.

Ahh. I see. It looks better without CodeMirror enabled.

Can you also switch the icon in the user script too, if OOUI lets you? I want to get some early feedback on that and the user script is very handy for that.

Can you also switch the icon in the user script too, if OOUI lets you? I want to get some early feedback on that and the user script is very handy for that.

Done. Although, the userscript code is now not the latest, and so contains some bugs. Now that we've moved messages out of the main JS file it's harder to just copy and paste things across. Let's deploy it on the commtech wiki. Although, perhaps it's also worth making a little wrapper that produces a usable userscript... do you think?

Can you also switch the icon in the user script too, if OOUI lets you? I want to get some early feedback on that and the user script is very handy for that.

Done. Although, the userscript code is now not the latest, and so contains some bugs. Now that we've moved messages out of the main JS file it's harder to just copy and paste things across. Let's deploy it on the commtech wiki. Although, perhaps it's also worth making a little wrapper that produces a usable userscript... do you think?

Nah, I think the user script is fine at the stage where it is. The icon was important because people are likely to comment on it.
Let's just work on the extension from now.

Change 420632 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Switch to use the OOUI puzzle icon

https://gerrit.wikimedia.org/r/420632