Page MenuHomePhabricator

Thank dialog success page has no "return back" link
Open, MediumPublic

Description

Steps to reproduce

  1. Open some diff in page history
  2. Click "thank" button
  3. Click "Thank the user" confirmation button on shown page
  4. See page: "You successfully thanked the user for that edit"

Click thanks:

Confirm thanking:

End up sad because I have no where to go:

Expected behavior
There should be some easy way or link to return back to diff from which you thanked.

Current behavior
There is no return link. So you have to click "back" button in your browser twice to go back.

Configuration
Firefox 58, tested on Czech Wikipedia

Event Timeline

Dvorapa created this task.Feb 26 2018, 10:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Restricted Application added a subscriber: Zoranzoki21. · View Herald TranscriptMar 6 2018, 6:36 PM
Catrope added a subscriber: Catrope.Mar 6 2018, 6:38 PM

(Note this only applies to the no-JS experience)

Catrope moved this task from Untriaged to Freezer on the Collaboration-Team-Triage board.

It's the same case for the no-js usage of adding a page to the watchlist from the star icon, that doesn't contain other link than the one to the user watchlist.

I don't know what you have, but I tried it with firefox 52 on Debian GNU/Linux I don't see any thing special, nothing is loaded, everything is done on client side. I don't need to click twice to go back. Maybe you can be more clearer?

Dvorapa added a comment.EditedMar 29 2018, 6:15 PM

Try to click thank button immediately after it is shown (when JavaScript hasn't been loaded yet – this is what I sometimes do and stuck with this problem) or try to turn JavaScript off in your browser preferences (in order to simulate that)

Mh-3110 added a subscriber: Mh-3110.Aug 5 2018, 8:45 AM

Hi @Dvorapa ,
I will start working on this task. But just to sure: this would be useful only in case user disable JS in the browser or open the link in a new tab. Right?
In that case I'm not sure there are so many users who disable Javascript in their browser or open the link in a new tab. I just need to be sure the feature will be really useful.
Thanks

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 5 2018, 8:45 AM

Hi @Dvorapa ,
I will start working on this task. But just to sure: this would be useful only in case user disable JS in the browser or open the link in a new tab. Right?
In that case I'm not sure there are so many users who disable Javascript in their browser or open the link in a new tab. I just need to be sure the feature will be really useful.
Thanks

Well, JavaScript is loaded few seconds after page is shown, therefore when user has a slow internet connection or is experienced computer user and clicks on the link in the first few seconds, it still uses no-JS function. I am getting this because I usually click on the link before JS loads in the page (in first few seconds).

Change 452275 had a related patch set uploaded (by Mh-3110; owner: Mahuton):
[mediawiki/extensions/Thanks@master] add return back link on Thanks extension sucess page

https://gerrit.wikimedia.org/r/452275

xSavitar triaged this task as Medium priority.Aug 12 2018, 11:22 PM
xSavitar updated the task description. (Show Details)EditedAug 21 2018, 8:00 PM

I'm also wondering about this issue, this seems legit but I'm wondering if just clicking on the "Read" link at the top of the page won't take you back to the page, sure it does? Rather than build a new feature for this, one can just click on the "Read" option before the "Edit" to dive back to the page right? See image below;

Hi @D3r1ck01 ,
sure but from what I what I understood the link should lead back to the history page not the article itself. (see attached scrreenshot)

Okay @Mh-3110, you're right. I got tricked by the "current behavior" part as if you click the "back" button twice, I think it takes you to the article itself? Maybe this only happens only in "no-JS" mode as @Catrope said?

yes @D3r1ck01 , this only happens on 'no-JS' mode. Clicking twice on the browser back button surely gets user back to the history page.

This is the final image I see with no link to go back to the diff.

Hi @D3r1ck01 , Don't get this point right.
Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

I'm testing on my local/development environment

Framawiki updated the task description. (Show Details)Aug 30 2018, 5:55 PM
Framawiki added subscribers: greg, Quiddity, darthbhyrava and 4 others.

Copy/pasting here an interesting comment from @Legoktm in the duplicate task:

We could add &returnto= support I guess.

In T188326#4532748, @D3r1ck01 wrote:

Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

I'm testing on my local/development environment

This is now fixed with the new patch set I submitted. See attached screeshot. Thanks

I've tested but 2 notices;

  1. The thanks doesn't seem to be sent to the target user.
  1. When the link "Return to history" is clicked, I get a "File not found" page.

See images below;

In T188326#4582891, @D3r1ck01 wrote:

I've tested but 2 notices;

  1. The thanks doesn't seem to be sent to the target user.
  1. When the link "Return to history" is clicked, I get a "File not found" page.

See images below;

Hi @D3r1ck01 ,
Thanks for testing.

  1. Thanks is sent to the right target as seen on my screenshots( tested in Vagrant)


  1. Maybe because some parameters of the URL are harcoded. Have submited a new patch set following your comment on gerrit.
kostajh added a subscriber: kostajh.

@Mh-3110 @D3r1ck01 thanks for working on this! Please let us know if you need any help.

Hi all,
I'm abandoning this task. Will come back to it if the functionality will be more pertinent to be implemented.
Thanks

Mh-3110 removed Mh-3110 as the assignee of this task.Sep 7 2019, 12:09 PM