Page MenuHomePhabricator
Create Task
Maniphest T188361

Fix the alignment for Beta features tab in Special:GlobalPreferences
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This includes making the mockups line up properly as they should.

Details

SubjectRepoBranchLines +/-
Don't interfere with BetaFeatures fields displaymediawiki/extensions/GlobalPreferencesmaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niharika triaged this task as Medium priority.Feb 27 2018, 1:57 AM
• Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2018, 1:57 AM
Samwilson subscribed.Feb 27 2018, 2:16 AM

We could make them OOUI ones, I guess. It's a bit more work to only to that on one tab, but you're right it would look better.

I don't suppose we want them to be OOUI on all tabs do we? (He asks hopefully.)

Addshore subscribed.Feb 27 2018, 10:16 AM

I agree, it would be nice to have the checkboxes on this page match:

image.png (517×867 px, 42 KB)

Quiddity subscribed.Feb 27 2018, 6:25 PM

That's T181864: Re-write the Beta Features preferences code to use OOUI, not re-implement bits of it with MWUI.

(See also:

• Niharika added a comment.Feb 27 2018, 6:54 PM
In T188361#4004726, @Samwilson wrote:

We could make them OOUI ones, I guess. It's a bit more work to only to that on one tab, but you're right it would look better.

We could also just give those checkboxes an extra class and make them look bigger and whiter in the CSS - your call. I suspect we'd have to revisit all this anyway when T117781: Convert Special:Preferences to OOUI happens (probably in the next 6 months).

I don't suppose we want them to be OOUI on all tabs do we? (He asks hopefully.)

Nah, we definitely don't want them to be OOUI on all tabs until T180538: Improve Special:Preferences UI/UX and T117781: Convert Special:Preferences to OOUI are done.

@Quiddity Yeah, saw those. Sam did a lot of work to make everything OOUI when T117781: Convert Special:Preferences to OOUI briefly happened. Sadly it got reverted and we had to undo all that work. :(

• Niharika moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Feb 27 2018, 9:21 PM
• TBolliger renamed this task from Fix the UI for Beta features tab in Special:GlobalPreferences to Fix the alignment for Beta features tab in Special:GlobalPreferences.Feb 28 2018, 12:39 AM
• TBolliger updated the task description. (Show Details)
• TBolliger set the point value for this task to 3.
• TBolliger moved this task from Needs Discussion to Up Next on the Community-Tech board.
• TBolliger subscribed.

All OOUI work for GlobalPrefs will be handled in T186842: Convert Special:GlobalPreferences to OOUI

This task is just about alignment.

• TBolliger edited projects, added Community-Tech-Sprint; removed Community-Tech.Feb 28 2018, 1:02 AM
Samwilson claimed this task.Mar 2 2018, 2:06 AM
Samwilson moved this task from Ready to In Development on the Community-Tech-Sprint board.
gerritbot subscribed.Mar 2 2018, 2:19 AM

Change 415795 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Don't interfere with BetaFeatures fields display

https://gerrit.wikimedia.org/r/415795

gerritbot added a project: Patch-For-Review.Mar 2 2018, 2:19 AM
Samwilson moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Mar 2 2018, 2:28 AM

This seems to be as simple as not interfering with the display of BetaFeatures weird preference types.

gerritbot added a comment.Mar 2 2018, 2:34 AM

Change 415795 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Don't interfere with BetaFeatures fields display

https://gerrit.wikimedia.org/r/415795

• Niharika closed this task as Resolved.Mar 2 2018, 6:19 PM
• Niharika moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.

Works great!

• TBolliger moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.Apr 11 2018, 11:57 PM
• Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jun 26 2018, 11:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL