| Esanders | |
| Feb 27 2018, 12:13 PM |
| F14874717: image.png | |
| Mar 9 2018, 9:51 PM |
| F14647764: Screenshot 2018-03-07 11.45.19.png | |
| Mar 7 2018, 6:43 PM |
We currently just show "Template parameters changed". The complication here is that a transclusion can be made up of multiple templates (e.g. a multi-template-generated table), but as a first step we could at least just handle the single template case.
ve.dm.MWTransclusionNode.static.describeChanges = function () {
// TODO: Provide a more detailed description of template changes
return [ ve.msg( 'visualeditor-changedesc-mwtransclusion' ) ];
};Change 417003 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWTransclusionNode: describe parameter changes for Visual Diffs
Change 417314 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] DiffElement: Allow rich content for change descriptions
Change 417314 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] DiffElement: Allow rich content for change descriptions
Change 417776 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3aabb95af)
Change 417776 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3aabb95af)
With that richer content, we get:
Each of these list-items is the base dm.Model's describeChange output. Looking at it, I'm thinking that now HTML works in this area, it might make sense to have that describeChange wrap the to/from values in a <code> or similar, so it's easier to tell. One area where some sort of flagging would make sense would be the empty-string-but-present case, which is legitimate and comes up in templates probably more than anywhere else.
Change 420849 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] DiffElement: Apply margin adjustment to ul as well in labels
Change 420849 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] DiffElement: Apply margin adjustment to ul as well in labels
Change 417003 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTransclusionNode: describe parameter changes for Visual Diffs
Change 421365 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bca1212a4)
Change 421365 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bca1212a4)
