Deduplicate entity ID lists in DependencyMetadata
Closed, ResolvedPublic
Actions

Description

If we don’t deduplicate entity ID lists in DependencyMetadata::merge, the cutoff of T188312: Don’t pass overly long entity ID lists to WikiPageEntityDataAccessor might be too low. Not sure. But in any case it probably means unnecessarily large queries for the revision information.

Details

	Subject	Repo	Branch	Lines +/-
	Deduplicate entity IDs in DependencyMetadata::merge()	mediawiki/extensions/WikibaseQualityConstraints	master	+33 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Resolved	Lydia_Pintscher	T179839 Cache constraint check results
Resolved	Lydia_Pintscher	T179849 Cache all constraint check results per-entity
Resolved	Lucas_Werkmeister_WMDE	T181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
Resolved	Lucas_Werkmeister_WMDE	T184812 Enable constraint result caching on Wikidata
Resolved	Lucas_Werkmeister_WMDE	T188312 Don’t pass overly long entity ID lists to WikiPageEntityDataAccessor
Resolved	Lucas_Werkmeister_WMDE	T188418 Deduplicate entity ID lists in DependencyMetadata

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as High priority.Feb 27 2018, 6:08 PM

Lucas_Werkmeister_WMDE created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2018, 6:08 PM

Change 415063 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Deduplicate entity IDs in DependencyMetadata::merge()

https://gerrit.wikimedia.org/r/415063

gerritbot added a project: Patch-For-Review.Feb 27 2018, 6:18 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-02-14.Feb 27 2018, 6:18 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-02-14 board.

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-02-28.Feb 28 2018, 9:44 AM

Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-02-28 board.

Change 415063 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Deduplicate entity IDs in DependencyMetadata::merge()

https://gerrit.wikimedia.org/r/415063

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 28 2018, 1:38 PM

Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-02-14 board.

Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-02-28 board.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 10:01 AM