Page MenuHomePhabricator

Special:EditTags limits the justification to length-155; consider changing this
Closed, ResolvedPublic

Description

The initially-uncommented limit to 60; post-T185948: Update web UI for increased comment length this is now limit-155 (=845 Unicode code points) "to leave room for the auto-generated part of the log entry", but maybe this is wrong?

Event Timeline

Jdforrester-WMF triaged this task as Low priority.Feb 27 2018, 10:27 PM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2018, 10:27 PM
Reedy updated the task description. (Show Details)Feb 27 2018, 11:18 PM
TTO added a comment.Feb 28 2018, 10:07 AM

It's likely that this code was copy-pasted out of RevisionDelete. I don't think tag log entries ever have autogenerated text.

DannyS712 added a subscriber: DannyS712.

They don't appear to have autogenerated text, so removing limit

Restricted Application added a project: User-DannyS712. · View Herald TranscriptThu, Aug 22, 2:48 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Thu, Aug 22, 2:48 AM

Change 531733 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Allow justifications in Special:EditTags to use full comment length

https://gerrit.wikimedia.org/r/531733

daniel added a subscriber: daniel.

Tagging CPT clinic duty for core review.

Change 531733 merged by jenkins-bot:
[mediawiki/core@master] Allow justifications in Special:EditTags to use full comment length

https://gerrit.wikimedia.org/r/531733

DannyS712 closed this task as Resolved.Fri, Aug 23, 10:51 AM
DannyS712 added a subscriber: Ladsgroup.

Removing CPT given that the change was +2'ed by @Ladsgroup before any CPT review