Page MenuHomePhabricator

Get some tests in for TemplateWizard
Closed, ResolvedPublic3 Estimated Story Points

Description

We should write some tests for TemplateWizard (extension).

Event Timeline

Niharika set the point value for this task to 3.Mar 6 2018, 11:54 PM

Change 417243 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[integration/config@master] Add QUnit to TemplateWizard

https://gerrit.wikimedia.org/r/417243

Is https://gerrit.wikimedia.org/r/#/c/417243/ sufficient to turn on qunit testing? (It should be failing at the moment, but maybe that's just because it's not merged in integration-config yet and the depends-on in https://gerrit.wikimedia.org/r/#/c/417234/ isn't having an effect.)

Change 417243 merged by jenkins-bot:
[integration/config@master] Add QUnit to TemplateWizard

https://gerrit.wikimedia.org/r/417243

Some tests are done for the template-formatting. No browser tests are being done; do we want them?

Some tests are done for the template-formatting. No browser tests are being done; do we want them?

We can skip browser tests.

Cool.

So https://gerrit.wikimedia.org/r/#/c/417234/ contains the tests (and other stuff...) and is ready for review. It also contains T186672 (sorry).

This got resolved with that patch. Thanks, Sam!