Page MenuHomePhabricator

CX2: Editing toolbar does not respect read-only state
Closed, ResolvedPublic

Description

When for example loading is in progress, the translation column is set to read-only. However it is still possible to apply styling changes using the editing toolbar.

Event Timeline

Pginer-WMF triaged this task as Medium priority.Mar 1 2018, 4:43 PM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

It's also possible to edit target title while page is loading, which can cause (recoverable) errors. We need to decide whether we want to allow changes to target title while page is loading, i.e. changes by manually typing or changing namespace from cog icon menu, which is currently disabled while loading, but we maybe don't want that option disabled.

Currently, error is caused by trying to align sections after target title change happens, but since surfaces aren't ready, there aren't really any sections to align. We can work around this of course, just need clear specs what we want while page is loading. @Pginer-WMF, any thoughts?

Currently, error is caused by trying to align sections after target title change happens, but since surfaces aren't ready, there aren't really any sections to align. We can work around this of course, just need clear specs what we want while page is loading. @Pginer-WMF, any thoughts?

I think the most practical approach is to keep it disabled until the document loads.

Supporting editing the title allows to do something while waiting, but it may result in complexity (e.g., how to interact with the warning system). So I think it may be better to consider the title as part of the document.

Nikerabbit claimed this task.
Nikerabbit moved this task from CX2 to Translation editor on the ContentTranslation board.

I cannot reproduce any errors. Loading generally seems much faster these days.