Page MenuHomePhabricator

CX2: Avoid jumpiness when header becomes sticky
Closed, ResolvedPublic

Description

Currently the transition between sticky/non-sticky when scrolling is a bit jumpy for the header as illustrated in this animation.

Normally this is caused by the fact that the part that becomes sticky gets removed from the rest of the page making it move up. One way to compensate that is to add some extra margin/padding to the underlying page as the header becomes sticky. If such margin is closer to the same size as the header that becomes sticky, the jump would be avoided.


This ticket is a follow-up of the work done in T186874: Adjust the styling of the title and personal headers in the translation editor

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2018, 12:19 PM

Change 415195 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Improve sticky behavior accuracy

https://gerrit.wikimedia.org/r/415195

There was already a patch for dealing with jumpiness. I have connected this ticket now. We agreed that https://gerrit.wikimedia.org/r/#/c/413695/ should be merged as is, and improved later by me, not to block other patches. That way we got imperfect stickiness.

Thanks for creating the ticket.

Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.

Change 415195 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Improve sticky behavior accuracy

https://gerrit.wikimedia.org/r/415195

Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 28 2018, 4:10 PM

Moved to Done column by accident. Returning to QA now.

Etonkovidova closed this task as Resolved.Mar 2 2018, 5:00 AM
Etonkovidova added a subscriber: Etonkovidova.

Checked the fix in cx2-testing.

Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 2 2018, 7:00 AM