Page MenuHomePhabricator
Create Task
Maniphest T188530

Externalize the parsing logic from SimpleKeywordFeature and FullTextQueryStringQueryBuilder
Closed, ResolvedPublic
Actions

Description

  • move out the regexes from SimpleKeywordFeature into a KeywordParser class.
  • move out all necessary regexes from FullTextQueryStringQueryBuilder in to Parser class
  • implement a minimal AST supported these queries

Details

SubjectRepoBranchLines +/-
Add QueryStringRegexParsermediawiki/extensions/CirrusSearchmaster+5 K -2
Promote some functions to KeywordFeaturemediawiki/extensions/CirrusSearchmaster+59 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse triaged this task as Medium priority.Feb 28 2018, 6:20 PM
dcausse created this task.
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptFeb 28 2018, 6:20 PM
dcausse moved this task from needs triage to Current work on the Discovery-Search board.Feb 28 2018, 6:20 PM
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot added a comment.Feb 28 2018, 6:23 PM

Change 415355 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Promote some functions to KeywordFeature

https://gerrit.wikimedia.org/r/415355

gerritbot added a project: Patch-For-Review.Feb 28 2018, 6:23 PM
gerritbot added a comment.Mar 12 2018, 5:21 PM

Change 418955 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add QueryStringRegexParser

https://gerrit.wikimedia.org/r/418955

dcausse renamed this task from Externalize the parsing logic from SimpleKeywordFeature to Externalize the parsing logic from SimpleKeywordFeature and FullTextQueryStringQueryBuilder.Mar 13 2018, 5:17 PM
dcausse updated the task description. (Show Details)
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.
gerritbot added a comment.Mar 14 2018, 11:00 PM

Change 415355 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Promote some functions to KeywordFeature

https://gerrit.wikimedia.org/r/415355

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 15 2018, 2:00 AM
gerritbot added a comment.Apr 3 2018, 6:25 PM

Change 418955 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add QueryStringRegexParser

https://gerrit.wikimedia.org/r/418955

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 2 2018, 11:30 PM
debt closed this task as Resolved.May 10 2018, 4:24 PM
Krinkle mentioned this in T236419: BUG: cannot consume query at offset 0 (need to go to 7296).Oct 24 2019, 6:17 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 24 2019, 7:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL