Page MenuHomePhabricator

Vector browser test blocking merge in Minerva
Closed, ResolvedPublic

Description

I'm not sure how this is happening but a Vector browser test introduced by Ib153f1d55e4471c4dc1e16ad3c9ae0ea9f73acf5 is running on Minerva and possibly other skins.

This is blocking merges in the repo... as we cannot manually override the "Verified +2" in that repo.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2018, 9:16 PM
Jdlrobson triaged this task as Unbreak Now! priority.Feb 28 2018, 9:17 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptFeb 28 2018, 9:17 PM
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptFeb 28 2018, 9:18 PM

Easiest thing to do would be to revert - https://gerrit.wikimedia.org/r/#/c/415393/
@zeljkofilipin I have no idea why Vector's browser tests are running on Minerva so ideally we'd fix that instead. Do you have any ideas? Ideally only the browser tests for the current skin should be running.

https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/15723/console

20:35:34 10 passing (79.30s)
20:35:34 1 failing
20:35:34 
20:35:34 1) User should be able to view new message banner:
20:35:34 An element could not be located on the page using the given search parameters ("div.usermessage").
20:35:34 running chrome
20:35:34 Error: An element could not be located on the page using the given search parameters ("div.usermessage").
20:35:34     at elements() - getText.js:18:17
20:35:34     at getText() - at Context.<anonymous> (skins/Vector/tests/selenium/specs/user.js:41:45)

@zeljkofilipin have spent much of today looking into this but can't work out what's going on. Hopefully can sync with you tomorrow to resolve this, if not I think we'll have to revert the patch until we work this out.

zeljkofilipin closed this task as Resolved.Mar 2 2018, 3:09 PM
zeljkofilipin added a subscriber: hashar.

@Jdlrobson why is mediawiki-core-qunit-selenium-jessie job running for Minerva, since it does not have Selenium tests?

Our Selenium framework is set up to run all tests it can find (wdio.conf.js). I did not know that CI jobs always clone Vector skin. So, when the test was merged there, it started running Vector tests even for commits in Minerva (example: 415373).

Resolved by 415393.

I have talked with @hashar about it, there are several ways we can fix the problem in CI. The work will continue in original task, T187859.