Page MenuHomePhabricator

PHPExcel fails PHP 7.0 lint
Closed, InvalidPublic

Description

https://integration.wikimedia.org/ci/job/mwext-testextension-php70-jessie-non-voting/762/console

16:31:33 ------------------------------------------------------------
16:31:33 Parse error: ./includes/PHPExcel/Calculation/Functions.php:574
16:31:33     572| 		} elseif(is_array($value)) {
16:31:33     573| 				return 64;
16:31:33   > 574| 				break;
16:31:33     575| 		} elseif(is_string($value)) {
16:31:33     576| 			//	Errors
16:31:33 Fatal error: 'break' not

Event Timeline

Legoktm triaged this task as High priority.Mar 1 2018, 5:05 AM
Legoktm created this task.

According to https://www.mediawiki.org/wiki/Extension:PHPExcel this is just a wrapper for a composer package? If that's the case, I'd rather archive this extension and point people to composer directly.

Change 416891 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/PHPExcel@master] Archive this extension

https://gerrit.wikimedia.org/r/416891

Change 416891 merged by Umherirrender:
[mediawiki/extensions/PHPExcel@master] Archive this extension

https://gerrit.wikimedia.org/r/416891

Umherirrender subscribed.

Now archived, checklist at T189238