Page MenuHomePhabricator

External link icon appearing twice
Closed, ResolvedPublic8 Estimated Story Points


Steps to reproduce:

  1. Open VE
  2. Insert an external link
  3. Save the page
  4. Reopen the page

Two external link icons are appearing next to the link

Event Timeline

Deskana changed the task status from Open to Stalled.Mar 2 2018, 11:09 AM
Deskana triaged this task as Medium priority.

I can't reproduce this in my sandbox on the English Wikipedia. How are you inserting the link, and what does it look like before and after you save?

Here are the screenshots:

Before saving:

Screen Shot 2018-03-02 at 2.46.50 PM.png (246×675 px, 14 KB)

After saving:

Screen Shot 2018-03-02 at 2.47.05 PM.png (211×380 px, 16 KB)

Ryasmeen changed the task status from Stalled to Open.Mar 2 2018, 10:49 PM

On enwiki (wmf.1) on your sandbox page (User:username/sandbox)

  • click the link icon and switch to the External tab in the Link inspector
  • type - click Insert - the display is correct
  • click Publish to save your changes - the display will be correct
  • click to open VE - double icons will be displayed:

Screen Shot 2018-04-27 at 1.59.29 PM.png (159×470 px, 27 KB)

Screen Shot 2018-04-27 at 2.04.23 PM.png (245×402 px, 32 KB)

Note: the external links can be added just by typing [ in VE to switch to insert link mode. Interwiki and internal links are ok.

This is due to a change in the Parsoid DOM spec (v1.6) which adds 'external' classes (T58756). We need to update our CE code.

Esanders raised the priority of this task from Medium to High.
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders set the point value for this task to 8.

Change 436544 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix parsing of external links, now Parsoid adds 'external' classes

Change 436544 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix parsing of external links, now Parsoid adds 'external' classes