Page MenuHomePhabricator

global_preferences.gp_user should be unsigned
Closed, ResolvedPublic


Although globaluser.gu_id isn't unsigned (it probably should be changed to be so), we should make global_preferences.gp_user in preparation, so it doesn't need a schema change in future

See also T62962 and T89737 (where cores user_properties.up_user was made unsigned! But not deployed yet)

Also, why is it INT(11) not just int?

Ping T184666: DBA review for GlobalPreferences schema

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

FWIW, it shouldn't take someone familiar with SQL and MW more than 10-15 minutes to fix this, and also include a migratory patch

Change 415924 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Make gp_user the same type as user_id

Change 415924 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Make gp_user the same type as user_id

Reedy removed a project: Patch-For-Review.