Page MenuHomePhabricator

global_preferences.gp_user should be unsigned
Closed, ResolvedPublic

Description

Although globaluser.gu_id isn't unsigned (it probably should be changed to be so), we should make global_preferences.gp_user in preparation, so it doesn't need a schema change in future

See also T62962 and T89737 (where cores user_properties.up_user was made unsigned! But not deployed yet)

Also, why is it INT(11) not just int?

Ping T184666: DBA review for GlobalPreferences schema

Event Timeline

Reedy created this task.Mar 1 2018, 7:33 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 1 2018, 7:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TBolliger triaged this task as Medium priority.Mar 1 2018, 8:56 PM
Reedy added a comment.Mar 1 2018, 10:32 PM

FWIW, it shouldn't take someone familiar with SQL and MW more than 10-15 minutes to fix this, and also include a migratory patch

MaxSem claimed this task.Mar 2 2018, 7:20 PM

Change 415924 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Make gp_user the same type as user_id

https://gerrit.wikimedia.org/r/415924

Change 415924 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Make gp_user the same type as user_id

https://gerrit.wikimedia.org/r/415924

Reedy closed this task as Resolved.Mar 2 2018, 11:25 PM
Reedy removed a project: Patch-For-Review.