Page MenuHomePhabricator
Create Task
Maniphest T188659

Notice: Undefined property: stdClass::$gt_primary in /srv/mediawiki/php-1.31.0-wmf.23/extensions/GeoData/includes/api/ApiQueryGeoSearchElastic.php on line 175
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Stacktrace:

#0 /srv/mediawiki/php-1.31.0-wmf.23/extensions/GeoData/includes/api/ApiQueryGeoSearchElastic.php(175): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.31.0-wmf.23/extensions/GeoData/includes/api/ApiQueryGeoSearch.php(40): GeoData\ApiQueryGeoSearchElastic->run()
#2 /srv/mediawiki/php-1.31.0-wmf.23/includes/api/ApiQuery.php(249): GeoData\ApiQueryGeoSearch->execute()
#3 /srv/mediawiki/php-1.31.0-wmf.23/includes/api/ApiMain.php(1580): ApiQuery->execute()
#4 /srv/mediawiki/php-1.31.0-wmf.23/includes/api/ApiMain.php(542): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.31.0-wmf.23/includes/api/ApiMain.php(513): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.31.0-wmf.23/api.php(94): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): include(string)
#8 {main}

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GeoDatamaster+1 -1Fix undefined property error in ApiQueryGeoSearchElastic
mediawiki/extensions/GeoDatawmf/1.31.0-wmf.23+1 -1Fix undefined property error in ApiQueryGeoSearchElastic
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Mar 1 2018, 8:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2018, 8:39 PM
thcipriani added a project: GeoData.Mar 1 2018, 8:41 PM
Krinkle added subscribers: MaxSem, • Mholloway, Krinkle.Mar 1 2018, 8:41 PM

Probably caused by 7997c22e9abeb42d7 / https://gerrit.wikimedia.org/r/#/c/412998/1/includes/api/ApiQueryGeoSearchElastic.php

Krinkle triaged this task as Unbreak Now! priority.Mar 1 2018, 8:43 PM
Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

Impact is presumably that the API is returning incorrect data that wrongly represents all Geo objects to be non-primary (PHP undefined, yielding null, casting to false).

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 1 2018, 8:43 PM
gerritbot added a subscriber: gerritbot.Mar 1 2018, 8:49 PM

Change 415654 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/GeoData@master] Fix undefined property error in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/415654

gerritbot added a project: Patch-For-Review.Mar 1 2018, 8:49 PM
gerritbot added a comment.Mar 1 2018, 8:56 PM

Change 415656 had a related patch set uploaded (by Thcipriani; owner: Mholloway):
[mediawiki/extensions/GeoData@wmf/1.31.0-wmf.23] Fix undefined property error in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/415656

Krinkle added a parent task: T183962: 1.31.0-wmf.23 deployment blockers.Mar 1 2018, 8:57 PM
• Mholloway added a comment.Mar 1 2018, 9:01 PM
In T188659#4015518, @Krinkle wrote:

Impact is presumably that the API is returning incorrect data that wrongly represents all Geo objects to be non-primary (PHP undefined, yielding null, casting to false).

That looks accurate.
https://he.wikipedia.org/w/api.php?action=query&list=geosearch&gsradius=10000&gscoord=37.786971%7C-122.399677

gerritbot added a comment.Mar 1 2018, 9:02 PM

Change 415654 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Fix undefined property error in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/415654

gerritbot added a comment.Mar 1 2018, 9:10 PM

Change 415656 merged by jenkins-bot:
[mediawiki/extensions/GeoData@wmf/1.31.0-wmf.23] Fix undefined property error in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/415656

Stashbot added a subscriber: Stashbot.Mar 1 2018, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-01T21:17:32Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.23/extensions/GeoData/includes/api/ApiQueryGeoSearchElastic.php: [[gerrit:415656|Fix undefined property error in ApiQueryGeoSearchElastic]] T188659 (duration: 01m 15s)

• Mholloway closed this task as Resolved.Mar 1 2018, 9:27 PM
• Mholloway claimed this task.
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Mar 4 2018, 4:16 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 12:01 PM
Reedy removed a project: Patch-For-Review.May 17 2019, 9:42 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 17 2019, 9:42 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:00 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL