Description

$( 'div.imeselector' ).hide();
$( 'div.imeselector-menu' ).removeClass( 'ime-open' );

On long pages with large DOM trees this in an inefficient operation to perform on every keystroke. It would be better to keep a list of active IMEs in memory somewhere and use that to close them.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/UniversalLanguageSelector	master	+6 -2	Update jquery.ime to 4b92dee

Customize query in gerrit

Event Timeline

Esanders created this task.Mar 2 2018, 7:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2018, 7:00 PM

https://github.com/wikimedia/jquery.ime/pull/509

Krinkle added a project: Performance-Team (Radar).Mar 2 2018, 7:14 PM

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Mar 2 2018, 7:29 PM

Amire80 moved this task from Backlog to Performance and stability on the UniversalLanguageSelector board.Mar 5 2018, 1:35 PM

Krinkle triaged this task as High priority.Jul 9 2018, 9:14 PM

PR #509 just got merged.

Change 452938 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.ime to 4b92dee

https://gerrit.wikimedia.org/r/452938

gerritbot added a project: Patch-For-Review.Aug 15 2018, 1:55 PM

Change 452938 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.ime to 4b92dee

https://gerrit.wikimedia.org/r/452938

Nikerabbit assigned this task to Esanders.Aug 15 2018, 2:21 PM

Nikerabbit edited projects, added Language-2018-July-September; removed Patch-For-Review.

Nikerabbit moved this task from Backlog to QA on the Language-2018-July-September board.

Krinkle awarded a token.Aug 15 2018, 2:45 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 15 2018, 3:00 PM

Etonkovidova closed this task as Resolved.Aug 22 2018, 11:19 PM

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Aug 23 2018, 6:13 AM

jQuery.ime performs two DOM queries on every keydownClosed, ResolvedPublicActions

Description

Details

Event Timeline

jQuery.ime performs two DOM queries on every keydown
Closed, ResolvedPublic
Actions