Page MenuHomePhabricator
Create Task
Maniphest T188773

Test to validate deletion log entries and ArticleDeleteComplete hook performers
Open, Needs TriagePublic
Actions

Description

Followup from T188479#4009190

Log entries in Special:Log/delete should have a test to valide the performer.

In T188479#4009190, @Legoktm wrote:

Via #mediawiki: <Sveta> Does mediawiki have a unit test for this?
Someone does need to do that. Multiple tests could have caught this - validating that the log entry inserted had the right performer, checking that the ArticleDeleteComplete hook got the right deleter, etc.

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2018, 7:34 PM
gerritbot added a subscriber: gerritbot.Mar 2 2018, 7:44 PM

Change 415477 had a related patch set uploaded (by Greg Grossmeier; owner: Jforrester):
[mediawiki/core@master] tests: Assert that the user who deleted a page is logged as such

https://gerrit.wikimedia.org/r/415477

Jdforrester-WMF renamed this task from Test to validate lot entries and ArticleDeleteComplete hook performers to Test to validate deletion log entries and ArticleDeleteComplete hook performers.Mar 2 2018, 7:47 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
gerritbot added a comment.Apr 26 2018, 1:07 AM

Change 415477 merged by jenkins-bot:
[mediawiki/core@master] tests: Assert that the user who deleted a page is logged as such

https://gerrit.wikimedia.org/r/415477

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL