Page MenuHomePhabricator
Create Task
Maniphest T188773

Test to validate deletion log entries and ArticleDeleteComplete hook performers
Open, Needs TriagePublic
Actions

Description

Followup from T188479#4009190

Log entries in Special:Log/delete should have a test to valide the performer.

In T188479#4009190, @Legoktm wrote:

Via #mediawiki: <Sveta> Does mediawiki have a unit test for this?

Someone does need to do that. Multiple tests could have caught this - validating that the log entry inserted had the right performer, checking that the ArticleDeleteComplete hook got the right deleter, etc.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+166 -0tests: Assert that the user who deleted a page is logged as such
Customize query in gerrit

Related Objects

Event Timeline

• thcipriani created this task.Mar 2 2018, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2018, 7:34 PM
greg added a project: Wikimedia-Incident.Mar 2 2018, 7:43 PM
greg moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.
gerritbot added a subscriber: gerritbot.Mar 2 2018, 7:44 PM

Change 415477 had a related patch set uploaded (by Greg Grossmeier; owner: Jforrester):
[mediawiki/core@master] tests: Assert that the user who deleted a page is logged as such

https://gerrit.wikimedia.org/r/415477

gerritbot added a project: Patch-For-Review.Mar 2 2018, 7:44 PM
Jdforrester-WMF renamed this task from Test to validate lot entries and ArticleDeleteComplete hook performers to Test to validate deletion log entries and ArticleDeleteComplete hook performers.Mar 2 2018, 7:47 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
zeljkofilipin added a project: MediaWiki-Core-Tests.Mar 5 2018, 10:04 AM
gerritbot added a comment.Apr 26 2018, 1:07 AM

Change 415477 merged by jenkins-bot:
[mediawiki/core@master] tests: Assert that the user who deleted a page is logged as such

https://gerrit.wikimedia.org/r/415477

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 26 2018, 2:00 AM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 15 2018, 12:53 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:54 PM
Krinkle edited projects, added Sustainability (Incident Followup); removed Wikimedia-Incident.Apr 28 2020, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL