Page MenuHomePhabricator
Create Task
Maniphest T188784

Regression: Nearby refreshes on search
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Visit https://en.m.wikipedia.org/wiki/Special:Nearby

Click in the search input.
Notice how the nearby results refresh.

Expected: they should not be impacted by search.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not refresh routes on all hash changesmediawiki/extensions/MobileFrontendmaster+3 -9
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Mar 2 2018, 9:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2018, 9:31 PM
Jdlrobson renamed this task from Nearby refreshes on search to Regression: Nearby refreshes on search.Mar 2 2018, 9:31 PM
Jdlrobson added a project: Regression.
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Mar 2 2018, 10:36 PM
• Niedzielski subscribed.Mar 2 2018, 10:55 PM

This appears to occur at least as far back as REL1_30 and is unrelated to the recent window and jQuery refactoring.

ovasileva triaged this task as Medium priority.Mar 5 2018, 5:17 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.Mar 6 2018, 1:00 PM
ovasileva set the point value for this task to 2.Mar 6 2018, 5:20 PM
ovasileva added a project: Readers-Web-Kanbanana-Board-Old.
Jdlrobson moved this task from Upcoming to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Mar 6 2018, 5:40 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Mar 9 2018, 4:33 PM
gerritbot subscribed.Mar 9 2018, 4:35 PM

Change 417979 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Do not refresh routes on all hash changes

https://gerrit.wikimedia.org/r/417979

gerritbot added a project: Patch-For-Review.Mar 9 2018, 4:35 PM
gerritbot added a comment.Mar 9 2018, 4:54 PM

Change 417979 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Do not refresh routes on all hash changes

https://gerrit.wikimedia.org/r/417979

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 9 2018, 5:01 PM
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Mar 9 2018, 5:01 PM
pmiazga removed a project: Patch-For-Review.Mar 9 2018, 5:12 PM
ovasileva subscribed.Mar 14 2018, 3:11 PM

@Jdlrobson - where can we test?

Jdlrobson added a comment.Mar 14 2018, 3:17 PM

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby

ovasileva added a comment.Mar 14 2018, 3:46 PM
In T188784#4050080, @Jdlrobson wrote:

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby

sorry, what I meant was, does it matter whether there's nothing in nearby or not?

Jdlrobson added a comment.Mar 14 2018, 3:47 PM

No. You'll still see the spinner if the bug is present.

ovasileva closed this task as Resolved.Mar 14 2018, 3:48 PM
ovasileva claimed this task.

looks good then!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits