| Fomafix | |
| Mar 3 2018, 10:18 AM |
| F27229136: Screen Shot 2018-11-15 at 11.17.00.png | |
| Nov 15 2018, 10:25 AM |
On read-only pages WikiEditor disables the editing of the textarea with the keyboard. The buttons for manipulating the textarea like bold are still active and change the textarea.
Expected behavior: The buttons for manipulating the textarea should be disabled on read-only pages.
Q: Anyone got ideas for how disabled buttons in WikiEditor 2010 should look ?
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/WikiEditor | master | +3 -0 | Toolbar: ignore modifications on readonly textarea |
This is only if the editor was force loaded, by something else having a dependency on it. MediaWiki-extensions-CodeMirror indeed does this. I suspect that reftoolbar might as well....
WikiEditor was never really designed for readonly pages however.
Change 473548 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/WikiEditor@master] Toolbar: ignore modifications on readonly textarea
With this change, the buttons are still enabled but don't work, which stops things being broken, at least. :-)
Change 473548 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Toolbar: ignore modifications on readonly textarea
Would look like:
Would have to apply to .tool > a, .tool-button, .tool-select .label, .wikiEditor-ui-toolbar .page-characters div span, but NOT the toggle elements.
and to all click handlers connected to those elements, nor the VE menu.