Page MenuHomePhabricator
Create Task
Maniphest T188860

1.31.0-wmf.23, 2018-03-04: "No results found" is shown when searching for an unavailable language in compact language links
Closed, ResolvedPublic
Actions

Description

The fix for T182539 was deployed, but now that I'm trying to do this in production, the old behavior appears to happen.

To reproduce:

Observed: "No such language"
Expected: "This page is not available in the language you searched for."

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UniversalLanguageSelectormaster+1 -1Fix custom no results again
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Mar 4 2018, 11:24 AM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptMar 4 2018, 11:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 mentioned this in T182539: Allow custom message instead of "No results found" in ULS for special scenarios.Mar 4 2018, 11:25 AM
Amire80 mentioned this in T186679: Test ULS Compact Language Links.Mar 4 2018, 11:27 AM
• Nikerabbit added a subscriber: • Nikerabbit.Mar 4 2018, 6:25 PM

My first guess would be that data-i18n value is wrong.

Amire80 triaged this task as High priority.Mar 4 2018, 7:01 PM
Amire80 moved this task from Backlog to Appearance and design on the ULS-CompactLinks board.
Arrbee added a project: Language-2018-Jan-Mar.Mar 5 2018, 7:12 AM
Arrbee moved this task from Backlog to Maintenance backlog on the Language-2018-Jan-Mar board.
Arrbee added a subscriber: Arrbee.

Timeboxed to EOD to catch the train

Arrbee assigned this task to • Nikerabbit.Mar 5 2018, 7:32 AM
gerritbot added a subscriber: gerritbot.Mar 5 2018, 1:18 PM

Change 416430 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/UniversalLanguageSelector@master] Fix custom no results again

https://gerrit.wikimedia.org/r/416430

gerritbot added a project: Patch-For-Review.Mar 5 2018, 1:18 PM
• Nikerabbit moved this task from Maintenance backlog to In Review on the Language-2018-Jan-Mar board.Mar 5 2018, 1:19 PM
Amire80 moved this task from In Review to QA on the Language-2018-Jan-Mar board.Mar 5 2018, 1:35 PM
Amire80 moved this task from Backlog to Compact Language Links on the UniversalLanguageSelector board.
gerritbot added a comment.Mar 5 2018, 1:51 PM

Change 416430 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Fix custom no results again

https://gerrit.wikimedia.org/r/416430

• Nikerabbit removed a project: Patch-For-Review.Mar 5 2018, 2:00 PM
KartikMistry moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 6 2018, 12:05 PM
• Petar.petkovic closed this task as Resolved.Mar 6 2018, 1:21 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 2:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL