scap fails on .eslintrc.json: invalid JSON
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Mar 5 2018, 2:05 PM

Description

Trying to scap the Popups extension:

ValueError: /srv/mediawiki-staging/php-1.31.0-wmf.23/extensions/Popups/.eslintrc.json is an invalid JSON file

The reason is eslint allows the "json" configuration file to have comments.

Run a full scap: scap sync

That took ~ 23 minutes :(

Mentioned In: T195343: JADE submodule on tin is dirty
Mentioned Here: rEPOP2d6bd5f4b789: Remove comments from json file - won't pass scap's json lint

If it doesn't adhere to the strict JSON spec, it shouldn't have a .json extension :(