Page MenuHomePhabricator

Query helper on embed.html always uses English language for labels of entities
Closed, ResolvedPublic

Description

embed.html’s renderEdit initializes the QueryHelper without any arguments, which means that it uses its default English language instead of the selected one (from ULS, cookies, navigator, etc.). This is especially annoying in conjunction with T188110: Support multilingual query templates, because it means that you will see English labels inside a translated query template text.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2018, 12:41 PM

Change 418956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Correctly initialize QueryHelper in embed.html

https://gerrit.wikimedia.org/r/418956

Change 418956 merged by jenkins-bot:
[wikidata/query/gui@master] Correctly initialize QueryHelper in embed.html

https://gerrit.wikimedia.org/r/418956

Jonas moved this task from Backlog to Done on the Wikidata Query UI board.
Jonas closed this task as Resolved.Mar 21 2018, 12:53 PM