Page MenuHomePhabricator

[BUG] Turn on reading list syncing? panel is presented after I turn on syncing
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

5/5

Steps to reproduce

  1. Fresh install, logged out
  2. Turn on reading list sync in Settings
  3. Respond to the "Log in to sync saved articles" alert by tapping on the "Log in or create account" button
  4. Log in

Expected results

Reading list sync is enabled, I am not prompted to "Enable syncing" via "Turn on reading list syncing" panel

Actual results

Reading list sync switch is already on but I am still prompted to"Enable syncing" via "Turn on reading list syncing" panel

Screenshots

Simulator Screen Shot - iPhone X - 2018-03-06 at 09.56.35.png (2×1 px, 245 KB)

Environments observed

App version: 1365 and latest develop
OS versions: 11.2.6
Device model: iPhone 6 Plus, iPhone 7 Plus, iPhone X simulator
Device language: en

Event Timeline

@cmadeo are you sure you're logged out/sync is disabled when you're opening the app? I'm seeing another bug related to that panel appearing when it shouldn't, after I re-install the app while being logged in & sync enabled, I still get asked if I want to enable sync (ticket here T190289)

But if I log out, remove the app, fresh install, go to Settings, enable sync, log in successfully, I'm not seeing that panel anymore (on 1370)

Oh! I'm sorry I was following the steps of T190289 :(
Let me re-test!

no problem, you caught the other bug 👏👍

Sorry about that, working great for me! Thanks so much @NHarateh_WMF !