Description
Details
Event Timeline
Change 416708 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] Deploy TemplateStyles to zhwiki
@Zoranzoki21 Please exercise some care. Right now I am the product owner for TemplateStyles, which means I have a duty to make sure everything goes okay. You scheduled a deployment within 30 minutes of this task being filed, which makes it very difficult for me to do that job. In this case, I was fortunate to have checked the workboard in time to notice. In future, please take a moment to consider if your haste may negatively impact others.
TemplateStyles has had initial testing done on the Swedish Wikipedia, where a few small bugs were found and fixed, and the extension is now being used. I'm happy to move along with deploying TemplateStyles to the Chinese Wikipedia so they can help beta test the extension. Thank you, Chinese Wikipedia users!
Does the page rendering issue affect this deployment? zhwiki still contains a lot of lint errors.
Remaining lint errors shouldn't be a problem. The wait for Remex was because wikitext like[1]
Lorem ipsum dolor sit amet, consectetur adipiscing elit,<templatestyles src="foo.css"/> sed do eiusmod tempor incididunt.
would incorrectly render like this with Raggett Tidy:
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit,</p> <style>...</style> <p>sed do eiusmod tempor incididunt.</p>
Note the paragraph is broken at the <style> tag.
What we want is what Remex will produce:
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit,<style>...</style> sed do eiusmod tempor incididunt.</p>
[1]: This is a bit simplified. In practice the wikitext would be more like elit,{{citation needed}} sed do eiusmod, and the <templatestyles/> would be inside the transcluded template. The misparsed end result is the same.
Change 446586 had a related patch set uploaded (by Gergő Tisza; owner: Zoranzoki21):
[operations/mediawiki-config@master] Deploy TemplateStyles to frwiki and zhwiki
Change 416708 abandoned by Zoranzoki21:
Deploy TemplateStyles to frwiki and zhwiki
Reason:
Abandoning as per T199909
Change 416708 abandoned by Gergő Tisza:
Deploy TemplateStyles to frwiki and zhwiki
Reason:
looks like gerrit created a new version when I rebased this: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /446586
Change 446586 merged by Gergő Tisza:
[operations/mediawiki-config@master] Deploy TemplateStyles to frwiki and zhwiki
Mentioned in SAL (#wikimedia-operations) [2018-07-19T11:18:43Z] <tgr@deploy1001> Synchronized wmf-config/InitialiseSettings.php: enable TemplateStyles on enwiki, frwiki, zhwiki T197603 T191452 T189022 (duration: 00m 55s)