ve.dm.Converter.static.renderHtmlAttributeList deep applying to handlesOwnChildren nodes causes errors
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Mar 6 2018, 4:48 PM

Description

Create a page with the following wikitext:
[[Image:VisualEditor-logo.svg|thumb|Test store]]

In VE, edit the caption to make 'Test' bold. Observe that your wikitext is now:

[[Image:VisualEditor-logo.svg|thumb|Test store]]

This is because renderHtmlAttributeList is using deep mode for handlesOwnChildren nodes (such as mw block images), and so is instructed to restore the attributes of originalElement.children[0] (the ) to targetElement.children[0] (the ).

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (f46b51b83)	mediawiki/extensions/VisualEditor	master	+1 -1
Don't descend into dataElement-generated nodes in renderHtmlAttributeList	VisualEditor/VisualEditor	master	+43 -6
Fix node type check	VisualEditor/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T187913: Small change to section header not displayed in historical visual diff
Mentioned Here: rGVEDf46b51b83f50: Merge "Add unit tests for autosave methods in DM surface"

Event Timeline

Esanders created this task.Mar 6 2018, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2018, 4:48 PM

Esanders mentioned this in T187913: Small change to section header not displayed in historical visual diff.Mar 6 2018, 4:49 PM

Change 416726 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix node type check

https://gerrit.wikimedia.org/r/416726

gerritbot added a project: Patch-For-Review.Mar 6 2018, 5:28 PM

Change 416731 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] WIP Failing test case for renderHtmlAttributeList

https://gerrit.wikimedia.org/r/416731

Esanders claimed this task.Mar 6 2018, 7:05 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 416726 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix node type check

https://gerrit.wikimedia.org/r/416726

Change 416731 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't descend into dataElement-generated nodes in renderHtmlAttributeList

https://gerrit.wikimedia.org/r/416731

Change 417033 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f46b51b83)

https://gerrit.wikimedia.org/r/417033

Change 417033 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f46b51b83)

https://gerrit.wikimedia.org/r/417033

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Mar 8 2018, 12:18 AM

Jdforrester-WMF removed a project: Patch-For-Review.

• Deskana closed this task as Resolved.Mar 8 2018, 10:39 AM

• Deskana set the point value for this task to 1.