Bot accounts should not trigger edit summary pings/mentions
Closed, ResolvedPublic2 Story Points

Description

If a user account has the bot right they should not trigger edit summary ping notifications.

Discussion in: T188960: Figure out which bots mention users in summaries, how often, and decide how 'Edit summary pings' should handle bots

TBolliger created this task.Mar 6 2018, 6:53 PM
TBolliger triaged this task as Normal priority.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 6 2018, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal added a subscriber: MusikAnimal.EditedMar 6 2018, 11:19 PM

I think we should take this a step further and disable pings for any edit made via the API -- not just bot edits -- unless it's given the new "allow ping" parameter (T189041). Looking at the Twinkle code alone (which I can fix, if need be), there are going to be a lot of unwanted pings. I think a few of my other scripts are also vulnerable. There must be many more.

The other option is to maybe get our liaisons to post on Village Pumps, etc., advertising that user scripts, gadgets, etc., will be affected by this and may need to be updated. Then perhaps a one-week waiting period before deployment?

Great point, Leon.

@Niharika @MaxSem — thoughts?

This would punch a hole through all our abstractions. Let's take a different look and identify all the problematic and widespread types of edit summaries.

TBolliger set the point value for this task to 2.

I ran some queries on recent changes, and it looks like most of the Twinkle edits that mention users are speedy deletion requests of the userpage. In this case we need to link to it, since that's the actual page in question, but probably fine that it pings, too? Other examples are warnings about conflict of interest, and reporting to UAA. These all are because the user is doing something semi-bad-faith, so not terrible to ping, but we also are leaving a message on their talk page, and in the case of speedy deletion, tagging the user page and logging it on the patrollers specified log page. So up to three echo notifications!

Overall I don't think we need to worry too much. I'll work on updating Twinkle to minimize the spam. There probably aren't that many other scripts as popular as Twinkle that ping, at least on enwiki.

Quick question, does prefixing with a colon prevent it from pinging? Like [[:User:Foo]]? If not, would that be hard to implement?

MaxSem added a comment.Mar 7 2018, 1:01 AM

It doesn't. Adding would be trivial.

It doesn't. Adding would be trivial.

Sweet :) I've created T189067. Thank you!

MaxSem claimed this task.

Change 416881 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Echo@master] Disable pings from summary for bots

https://gerrit.wikimedia.org/r/416881

Change 416881 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Disable pings from summary for bots

https://gerrit.wikimedia.org/r/416881

MaxSem closed this task as Resolved.

Change 417330 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Echo@wmf/1.31.0-wmf.24] Disable pings from summary for bots

https://gerrit.wikimedia.org/r/417330

Change 417330 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.31.0-wmf.24] Disable pings from summary for bots

https://gerrit.wikimedia.org/r/417330