Page MenuHomePhabricator

WikibaseMediaInfo tests are failing: Argument 1 passed to Wikibase\MediaInfo\Maintenance\Util\PagePropsUpdateGenerator::__construct() must be an instance of Wikibase\Lib\EntityIdComposer, instance of Wikibase\DataModel\Services\EntityId\EntityIdComposer given
Closed, ResolvedPublic

Description

05:10:31 [d2af3ab21c33dffd88bfa974] [no req]   TypeError from line 24 of /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/extensions/WikibaseMediaInfo/maintenance/Util/PagePropsUpdateGenerator.php: Argument 1 passed to Wikibase\MediaInfo\Maintenance\Util\PagePropsUpdateGenerator::__construct() must be an instance of Wikibase\Lib\EntityIdComposer, instance of Wikibase\DataModel\Services\EntityId\EntityIdComposer given, called in /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/extensions/WikibaseMediaInfo/maintenance/CreatePageProps.php on line 73
05:10:31 Backtrace:
05:10:31 #0 /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/extensions/WikibaseMediaInfo/maintenance/CreatePageProps.php(73): Wikibase\MediaInfo\Maintenance\Util\PagePropsUpdateGenerator->__construct(Wikibase\DataModel\Services\EntityId\EntityIdComposer)
05:10:31 #1 /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/maintenance/Maintenance.php(1651): Wikibase\MediaInfo\Maintenance\CreatePageProps->doDBUpdates()
05:10:31 #2 /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/maintenance/update.php(212): LoggedUpdateMaintenance->execute()
05:10:31 #3 /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/maintenance/doMaintenance.php(94): UpdateMediaWiki->execute()
05:10:31 #4 /home/jenkins/workspace/mwext-testextension-php70-composer-jessie-non-voting/src/maintenance/update.php(245): require_once(string)
05:10:31 #5 {main}

This is happening in the hhvm job too (but that one has no stack trace).

Event Timeline

Legoktm created this task.Mar 7 2018, 5:12 AM
Legoktm triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptMar 7 2018, 5:12 AM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 7 2018, 6:12 PM

Change 416998 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix EntityIdComposer class

https://gerrit.wikimedia.org/r/416998

thiemowmde closed this task as Resolved.Mar 7 2018, 6:22 PM

Change 416998 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix EntityIdComposer class

https://gerrit.wikimedia.org/r/416998