Page MenuHomePhabricator
Create Task
Maniphest T189120

Merge ve.dm.LinearData/FlatLinearData/ElementLinearData
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Now that 2D metadata doesn't exist, these separate store types are no longer necessary, we previously used

  • ElementLinearData for "real" non-meta data
  • FlatLinearData for a mix of ElementLinearData and MetaLinearData before they had been separated and aligned
  • MetaLinearData for meta data
  • LinearData to be a common parent of ElementLinearData and MetaLinearData

Now we no longer have MetaLinearData, both Flat* and Element* become redundant separations.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (f46b51b83)mediawiki/extensions/VisualEditormaster+1 -1
Stop using FlatLinearData directlyVisualEditor/VisualEditormaster+15 -18
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 7 2018, 2:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2018, 2:34 PM
gerritbot subscribed.Mar 7 2018, 2:48 PM

Change 416955 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Stop using FlatLinearData directly

https://gerrit.wikimedia.org/r/416955

gerritbot added a project: Patch-For-Review.Mar 7 2018, 2:49 PM
gerritbot added a comment.Mar 7 2018, 7:49 PM

Change 416955 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Stop using FlatLinearData directly

https://gerrit.wikimedia.org/r/416955

gerritbot added a comment.Mar 7 2018, 9:00 PM

Change 417033 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f46b51b83)

https://gerrit.wikimedia.org/r/417033

gerritbot added a comment.Mar 7 2018, 11:26 PM

Change 417033 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f46b51b83)

https://gerrit.wikimedia.org/r/417033

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 8 2018, 12:01 AM
• Deskana closed this task as Resolved.Mar 8 2018, 10:44 AM
• Deskana assigned this task to Esanders.
• Deskana triaged this task as Medium priority.
• Deskana moved this task from To Triage to Current work on the VisualEditor board.
• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.
• Deskana moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
• Deskana set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits