The following div is added by the VisualEditor in every reference:
<div id="KJWFkfRroD" class="donut-container" style="cursor: pointer; display: -webkit-inline-box; width: 0px; height: 0px;"></div>
See https://fr.wikipedia.org/w/index.php?title=R%C3%A9gime_amaigrissant&diff=146196702&oldid=145678887
It's currently reproduceable on that page with Chrome and Firefox.
| mediawiki/extensions/VisualEditor : wmf/1.33.0-wmf.6 | Fix filtering out .donut-container again |
| mediawiki/extensions/VisualEditor : master | Fix filtering out .donut-container again |
| mediawiki/extensions/VisualEditor : wmf/1.31.0-wmf.24 | Blacklist Web of Trust junk from being added to pages |
| mediawiki/extensions/VisualEditor : master | Blacklist Web of Trust junk from being added to pages |
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Invalid | None | T54327 Broken browser plugins cause cruft to be injected into the page (tracking) | ||
| Resolved | matmarex | T189148 "donut-container" <div> added in every <ref> |
I can't reproduce this. Can you provide detailed steps needed to make this happen?
Problems like this are often caused by browser extensions inserting things into pages. Do you have any extensions installed that do anything related to… donuts? If we find out where this is coming from, we could probably blacklist it.
There are a few other pages on fr.wp that are affected by this problem: https://fr.wikipedia.org/w/index.php?search=insource%3Adonut-container&profile=all
Some also have a "reactroot" div, which seems vaguely related (some pages have both): https://fr.wikipedia.org/w/index.php?search=insource%3Areactroot&profile=all
I just found out: it's the extension "WOT: Web of Trust"
https://addons.mozilla.org/firefox/addon/wot-safe-browsing-tool/
https://chrome.google.com/webstore/detail/wot-web-of-trust-website/bhmmomiinigofkjcapegjjndpbikblnp
Its symbol is a donut.
Change 417037 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Blacklist Web of Trust junk from being added to pages
It would be nice if we could contact them and ask them to stop inserting this into contenteditable elements… The patch above should stop this from appearing in pages now, but it will easily break e.g. if they decide to use some more reasonable attribute than class="donut-container" to identify their stuff.
They already have a special case for Wikipedia in the configuration: http://static-cdn.mywot.com/settings/extensions/serps.json so hopefully it wouldn't be difficult for them to do?
Change 417037 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Blacklist Web of Trust junk from being added to pages
Change 417177 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] Blacklist Web of Trust junk from being added to pages
Change 417177 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] Blacklist Web of Trust junk from being added to pages
Mentioned in SAL (#wikimedia-operations) [2018-03-08T14:37:24Z] <zfilipin@tin> Synchronized php-1.31.0-wmf.24/extensions/VisualEditor/modules/ve-mw/init/ve.init.mw.Target.js: SWAT: [[gerrit:417177|Blacklist Web of Trust junk from being added to pages (T189148)]] (duration: 01m 15s)
The problem continues: https://ru.wikipedia.org/w/index.php?title=%D0%9D%D0%B5%D0%B2%D0%B8%D0%BD%D0%BD%D0%BE%D1%81%D1%82%D1%8C_%D0%BC%D1%83%D1%81%D1%83%D0%BB%D1%8C%D0%BC%D0%B0%D0%BD&diff=96622567&oldid=95790187 , https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%A2%D0%B5%D1%85%D0%BD%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D0%B9#%D0%9F%D0%BE%D1%8F%D0%B2%D0%BB%D1%8F%D1%8E%D1%89%D0%B8%D0%B9%D1%81%D1%8F_%D0%B8%D0%B7_%D0%BD%D0%B8%D0%BE%D1%82%D0%BA%D1%83%D0%B4%D0%B0_%D0%BA%D0%BE%D0%B4
@MaxBioHazard Thank you for noticing. I found that this has been broken by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/473809.
Change 478808 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix filtering out .donut-container again
Change 478808 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix filtering out .donut-container again
Change 478975 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.6] Fix filtering out .donut-container again
Change 478975 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.6] Fix filtering out .donut-container again
The patch was deployed to all projects and the problem shouldn't occur for any new edits. You can find existing affected pages using the wiki search feature, for example: https://ru.wikipedia.org/w/index.php?search=insource%3Adonut-container&profile=all
Sorry about this!