Label not shown for lexical category and/or language edit diff of a Lexeme
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Mar 8 2018, 9:34 AM

Description

When viewing a diff of a change of the lexical category and/or language of a Lexeme the label for the item is not shown and instead only the Q-ID.
The label should be shown in the user's ULS language (or a fallback when not available - same "Fallback Chain" as everywhere else for item labels).

Example diff:

Example diff with item labels shown:

The same diff in qqx language with fallback:

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T189187 Label not shown for lexical category and/or language edit diff of a Lexeme
Resolved	WMDE-leszek	T189678 Use the correct formatter when visualizing the lexical category difference in the lexeme diff
Resolved	Addshore	T189679 Use the correct formatter when visualizing the language difference in the lexeme diff

Event Timeline

Lydia_Pintscher created this task.Mar 8 2018, 9:34 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 8 2018, 9:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lydia_Pintscher renamed this task from label not shown for lexical category edit of a Lexeme to label not shown for lexical category edit diff of a Lexeme.Mar 8 2018, 9:34 AM

Lydia_Pintscher triaged this task as Medium priority.Mar 8 2018, 9:37 AM

WMDE-leszek renamed this task from label not shown for lexical category edit diff of a Lexeme to Label not shown for lexical category edit diff of a Lexeme.Mar 12 2018, 12:27 PM

WMDE-leszek updated the task description. (Show Details)

Addshore updated the task description. (Show Details)Mar 12 2018, 12:28 PM

Some technical signposts in WikibaseLexeme:

LexemeDiffVisualizer::visualizeEntityDiff
LexemeDiff::getLexicalCategoryDiff
LexemeDiff::lexicalCategory ?

And some in Wikibase:

WikibaseRepo::getEntityDiffVisualizerFactory
which makes a DifferencesSnakVisualizer passing in a $entityIdFormatter from WikibaseRepo::getEntityIdHtmlLinkFormatterFactory
this is most likely the formater that formats the item ID in html for output in a diff with the language fallback.
You can seethis during the construction when a LanguageFallbackLabelDescriptionLookupFactory is passed in

AFAICT this also concerns the diffing edits which touched the language field of the lexeme. This could potentially be seen as the same bug/story.

Addshore mentioned this in T189186: label not shown for grammatical feature in diff of a Form.Mar 13 2018, 9:56 AM

WMDE-leszek set the point value for this task to 5.Mar 13 2018, 10:44 AM

• RazShuty added a project: Wikidata-Turtles-18.03.14.Mar 14 2018, 10:33 AM

WMDE-leszek updated the task description. (Show Details)Mar 14 2018, 12:13 PM

WMDE-leszek updated the task description. (Show Details)Mar 14 2018, 12:18 PM

WMDE-leszek updated the task description. (Show Details)

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 14 2018, 12:51 PM

WMDE-leszek updated the task description. (Show Details)Mar 14 2018, 1:13 PM

Addshore moved this task from To Do to Doing on the Wikidata-Turtles-18.03.14 board.Mar 21 2018, 10:06 AM

Jakob_WMDE moved this task from Doing to Test (Product Review) on the Wikidata-Turtles-18.03.14 board.Mar 26 2018, 11:13 AM

• RazShuty added a project: Wikidata-Turtles-18.03.28.Mar 28 2018, 9:32 AM

• RazShuty moved this task from To Do to Test (Product Review) on the Wikidata-Turtles-18.03.28 board.

Lydia_Pintscher closed this task as Resolved.Apr 3 2018, 9:53 AM

Lydia_Pintscher claimed this task.

Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Turtles-18.03.14 board.

Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Turtles-18.03.28 board.

Jakob_WMDE closed subtask T189679: Use the correct formatter when visualizing the language difference in the lexeme diff as Resolved.Apr 3 2018, 10:00 AM

Jakob_WMDE closed subtask T189679: Use the correct formatter when visualizing the language difference in the lexeme diff as Resolved.

Jakob_WMDE closed subtask T189678: Use the correct formatter when visualizing the lexical category difference in the lexeme diff as Resolved.

	F15196648: lexcat-diff3.png
	Mar 12 2018, 4:43 PM

	F15196634: lexcat-diff1.png
	Mar 12 2018, 4:43 PM

	F15196640: lexcat-diff2.png
	Mar 12 2018, 4:43 PM

Label not shown for lexical category and/or language edit diff of a LexemeClosed, ResolvedPublic5 Estimated Story PointsActions

Description

Related ObjectsSearch...

Event Timeline

Label not shown for lexical category and/or language edit diff of a Lexeme
Closed, ResolvedPublic5 Estimated Story Points
Actions

Related Objects
Search...