Regression: Talk overlay is not showing on pages which do not yet have a talk page
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

Log in to wikipedia
Switch to mobile version
Go to non-existent page, like https://en.m.wikipedia.org/wiki/Iadsfadf

Expected results

19:06:12 Scenario: Talk on a page that doesn't exist (bug 64268) # tests/browser/features/talk.feature:16
19:07:07 Given I am logged into the mobile website # tests/browser/features/step_definitions/common_steps.rb:22
19:07:07 And I am on a page that does not exist # tests/browser/features/step_definitions/common_steps.rb:29
19:07:07 When I click the talk button # tests/browser/features/step_definitions/talk_steps.rb:1
19:07:07 Then I should see the talk overlay

Actual results

Overlay fails to open.

Spotted in this browser test

Failing since these two commits
Issue since at least wmf/1.31.0-wmf.20

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Run browser test on per commit basis	mediawiki/skins/MinervaNeue	master	+1 -1
	Fix talk overlay behaviour for pages with blank talk pages	mediawiki/extensions/MobileFrontend	master	+12 -2

Customize query in gerrit

Related Objects

Mentioned In: T173539: Abandon use of globals in MobileFrontend classes
T184273: Adding a discussion to a user talk page should show the new topic without refresh

Event Timeline

Jdrewniak created this task.Mar 8 2018, 10:24 AM

Jdrewniak triaged this task as Medium priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2018, 10:24 AM

Jdrewniak moved this task from Incoming to Upcoming on the Web-Team-Backlog-Archived board.Mar 8 2018, 10:25 AM

Jdrewniak added a project: MinervaNeue.Mar 8 2018, 10:42 AM

• Niedzielski updated the task description. (Show Details)Mar 8 2018, 1:35 PM

Jdlrobson renamed this task from [Bug] Talk button visible on non-existent pages to [Bug] Talk overlay is not showing on pages which do not yet have a talk page.Mar 8 2018, 10:39 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T184273: Adding a discussion to a user talk page should show the new topic without refresh.Mar 8 2018, 10:50 PM

Jdlrobson renamed this task from [Bug] Talk overlay is not showing on pages which do not yet have a talk page to Regression: Talk overlay is not showing on pages which do not yet have a talk page.Mar 8 2018, 10:56 PM

Change 417462 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Fix talk overlay behaviour for pages with blank talk pages

https://gerrit.wikimedia.org/r/417462

gerritbot added a project: Patch-For-Review.Mar 8 2018, 10:56 PM

Jdlrobson mentioned this in T173539: Abandon use of globals in MobileFrontend classes.Mar 8 2018, 11:03 PM

Change 417461 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Run browser test on per commit basis

https://gerrit.wikimedia.org/r/417461