Page MenuHomePhabricator

Regression: Talk overlay is not showing on pages which do not yet have a talk page
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Log in to wikipedia
  2. Switch to mobile version
  3. Go to non-existent page, like https://en.m.wikipedia.org/wiki/Iadsfadf

Expected results

19:06:12 Scenario: Talk on a page that doesn't exist (bug 64268) # tests/browser/features/talk.feature:16
19:07:07 Given I am logged into the mobile website # tests/browser/features/step_definitions/common_steps.rb:22
19:07:07 And I am on a page that does not exist # tests/browser/features/step_definitions/common_steps.rb:29
19:07:07 When I click the talk button # tests/browser/features/step_definitions/talk_steps.rb:1
19:07:07 Then I should see the talk overlay

Actual results

  • Overlay fails to open.

Spotted in this browser test

Failing since these two commits
Issue since at least wmf/1.31.0-wmf.20

Event Timeline

Jdrewniak triaged this task as Normal priority.Mar 8 2018, 10:24 AM
Jdrewniak created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2018, 10:24 AM
Niedzielski updated the task description. (Show Details)Mar 8 2018, 1:35 PM
Jdlrobson renamed this task from [Bug] Talk button visible on non-existent pages to [Bug] Talk overlay is not showing on pages which do not yet have a talk page.Mar 8 2018, 10:39 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from [Bug] Talk overlay is not showing on pages which do not yet have a talk page to Regression: Talk overlay is not showing on pages which do not yet have a talk page.Mar 8 2018, 10:56 PM

Change 417462 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Fix talk overlay behaviour for pages with blank talk pages

https://gerrit.wikimedia.org/r/417462

Change 417461 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Run browser test on per commit basis

https://gerrit.wikimedia.org/r/417461

Regression caused by work in current sprint so I'm pulling it in.

Change 417462 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix talk overlay behaviour for pages with blank talk pages

https://gerrit.wikimedia.org/r/417462

Skipping QA as this fix can be verified by browser test.

Change 417461 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Run browser test on per commit basis

https://gerrit.wikimedia.org/r/417461