Use the new comment table for summaries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MusikAnimal
	Mar 8 2018, 7:09 PM

Description

rev_comment, log_comment, etc. are now deprecated. Comments live in the comment table. Everything at https://www.mediawiki.org/wiki/Manual:Database_layout is up-to-date.

This task depends on the comments being backfilled as part of T166733: Deploy refactored comment storage

Related Objects

Mentioned In: rXT587f2b81c792: Use new comment table for fetching edit and log summaries
rXTe2f7f913b4fd: Use new comment table for fetching edit and log summaries
T208696: Request to add tool to AutoEdits
rXT1d2ffa169d39: Update relevant queries to use new comment table
rXT7e2dd38bfb28: Add warning about missing summaries (T189234)
T208156: Replace tracking task T119681 by creating #MediaWiki-Commenting
Mentioned Here: T166733: Deploy refactored comment storage

Event Timeline

MusikAnimal created this task.Mar 8 2018, 7:09 PM

Restricted Application added a subscriber: • OldUser02. · View Herald TranscriptMar 8 2018, 7:09 PM

MusikAnimal renamed this task from Update to use the new comment table for summaries to Use the new comment table for summaries.Mar 8 2018, 7:10 PM

MusikAnimal claimed this task.

MusikAnimal moved this task from Backlog to Working on the XTools board.

Err, the replicas aren't using it yet. Putting on hold.

T166733#4694462
time to update all our tools and scripts
:(

Lofhi subscribed.Oct 25 2018, 8:41 PM

In T189234#4695820, @Framawiki wrote:

T166733#4694462
time to update all our tools and scripts
:(

Access to the raw (okay, filtered) DBs has some advantages but it does mean you don't get a stable API etc.

XTools can't feasibly use the API. But anyway I'm seeing some missing historical data:

MariaDB [enwiki_p]> SELECT rev_comment, rev_comment_id FROM revision WHERE rev_id = 523232421\G;
*************************** 1. row ***************************
   rev_comment: [[WP:AES|←]]Created page with '[[Category:Professional wrestling championships by promotion]] [[Category:Women's professional wrestling championships]]  ja:Category:NEO女子プロレスの...'
rev_comment_id: 0
1 row in set (0.12 sec)

where the rev_comment_id is 0

In T189234#4695858, @Krenair wrote:

Access to the raw (okay, filtered) DBs has some advantages but it does mean you don't get a stable API etc.

Of course, I understand changes are needed.

MGChecker mentioned this in T208156: Replace tracking task T119681 by creating #MediaWiki-Commenting.Oct 28 2018, 8:30 PM

MusikAnimal changed the task status from Open to Stalled.Oct 30 2018, 4:18 PM

MusikAnimal triaged this task as High priority.

MusikAnimal updated the task description. (Show Details)

MusikAnimal mentioned this in rXT7e2dd38bfb28: Add warning about missing summaries (T189234).Oct 30 2018, 5:22 PM

MusikAnimal mentioned this in rXT1d2ffa169d39: Update relevant queries to use new comment table.Oct 31 2018, 11:44 PM

Temporary fix has been added to check both revision/logging and comment. Leaving this in the Blocked column while we wait for confirmation that comments have been fully backfilled, at which time we'll remove the querying for rev_comment/log_comment entirely.