Page MenuHomePhabricator
Create Task
Maniphest T189242

[Bug] Image clicks are ignored by searchSatisfaction
Closed, ResolvedPublic
Actions

Description

In T188421#4034622, @dcausse found that image clicks are ignored by searchSatisfaction because SRP click events only recognize '.mw-search-result-heading a, #mw-search-DYM-suggestion, #mw-search-DYM-original, #mw-search-DYM-rewritten'. See https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaEvents/+/master/modules/all/ext.wikimediaEvents.searchSatisfaction.js#670

Besides fixing it for image results, we may also want to consider:

  • Is there any other types of result ignored by searchSatisfaction?
  • Does this bug affect visitPage event?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Track clicks to thumbnails on searchmediawiki/extensions/WikimediaEventsmaster+3 -3
Give search results a consistent css class to selectmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• chelsyx created this task.Mar 8 2018, 7:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2018, 7:58 PM
• chelsyx added a comment.Mar 8 2018, 8:00 PM
This comment was removed by • chelsyx.
• chelsyx mentioned this in T188421: Investigate the full-text desktop search CTR decline on Wikimedia Commons.Mar 8 2018, 8:02 PM
• EBjune triaged this task as Medium priority.Jun 7 2018, 5:19 PM
• EBjune moved this task from needs triage to This Quarter on the Discovery-Search board.
• chelsyx added a subscriber: • Ramsey-WMF.Aug 2 2018, 8:18 PM

@Ramsey-WMF JK said you are actively looking into the search clickthrough rate on Commons, and this bug is making the rate lower than it should be. How soon do you want it to get fixed?

• Ramsey-WMF added a comment.Aug 2 2018, 8:52 PM

@chelsyx Ideally we'd have that fixed this quarter so we can start measuring baseline pre-SDC search numbers next quarter before we launch search on structured data in Jan.

EBernhardson moved this task from This Quarter to search-icebox on the Discovery-Search board.Sep 11 2018, 5:22 PM
EBernhardson moved this task from search-icebox to Current work on the Discovery-Search board.
EBernhardson edited projects, added: Discovery-Search (Current work); removed: Discovery-Search.
EBernhardson claimed this task.Sep 11 2018, 8:52 PM
EBernhardson moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.
EBernhardson moved this task from Needs Reporting to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Sep 13 2018, 6:58 PM

Change 460414 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikimediaEvents@master] Track clicks to thumbnails on search

https://gerrit.wikimedia.org/r/460414

gerritbot added a project: Patch-For-Review.Sep 13 2018, 6:58 PM

Change 460412 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/core@master] Give search results a consistent css class to select

https://gerrit.wikimedia.org/r/460412

EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Sep 13 2018, 7:03 PM
gerritbot added a comment.Sep 14 2018, 7:40 PM

Change 460412 merged by jenkins-bot:
[mediawiki/core@master] Give search results a consistent css class to select

https://gerrit.wikimedia.org/r/460412

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 14 2018, 8:00 PM
gerritbot added a comment.Sep 18 2018, 1:30 PM

Change 460414 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Track clicks to thumbnails on search

https://gerrit.wikimedia.org/r/460414

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 18 2018, 5:17 PM
• Ramsey-WMF added a comment.Oct 3 2018, 7:40 PM

Did this fix ever got deployed? If not, can we do that soon? :)

EBernhardson added a comment.Oct 3 2018, 7:46 PM

Per the tags from ReleaseTaggerBot this should have been deployed with wmf.22, and we are now on wmf.23 with .24 rolling out. So this should be deployed.

Looking at the project search metrics for commonswiki we can see a large bump in engagement around 9/20, and a dramatic return of clickthrough rates to prior levels. SAL logs confirm wmf.22 was deployed on 9/20.

• Ramsey-WMF closed this task as Resolved.Oct 3 2018, 7:54 PM

Cool. Thanks @EBernhardson . Looks like this is resolved so I'm gonna go ahead and close this ticket.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits