Page MenuHomePhabricator
Create Task
Maniphest T189267

Invisible templates are unexpectedly large
Closed, ResolvedPublic
Actions

Assigned To
DLynch
Authored By
• Whatamidoing-WMF
Mar 8 2018, 11:12 PM
Tags
Referenced Files
F15409841: image.png
Mar 14 2018, 3:19 PM
F15382043: image.png
Mar 14 2018, 10:44 AM
F15382073: image.png
Mar 14 2018, 10:44 AM
F14769916: Screen Shot 2018-03-08 at 2.55.24 PM.png
Mar 8 2018, 11:12 PM
Subscribers
Aklapper
DLynch
gerritbot
Jdforrester-WMF
jeblad
Kerry_Raymond
matmarex
View All 10 Subscribers

Description

The note to indicate the presence of an "invisible" templates is now unexpectedly large:

Screen Shot 2018-03-08 at 2.55.24 PM.png (129×358 px, 26 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ce.MWTransclusionNode: increase invisible selector specificitymediawiki/extensions/VisualEditorwmf/1.31.0-wmf.24+1 -1
ce.MWTransclusionNode: increase invisible selector specificitymediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Mar 8 2018, 11:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2018, 11:12 PM
• Deskana triaged this task as Unbreak Now! priority.Mar 8 2018, 11:14 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 8 2018, 11:14 PM
• Deskana moved this task from To Triage to Current work on the VisualEditor board.Mar 8 2018, 11:14 PM
• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.
DLynch claimed this task.Mar 9 2018, 1:17 AM
DLynch subscribed.

Let's see... bisect says introduced in 55a30052a89e2a662568f90acaf40d9e8763b0b5, which was an update-submodule commit, and looking through that... 5f6664e2eadc23c2f041ec53a4ee31dd88bab5d0 caused this.

gerritbot subscribed.Mar 9 2018, 1:29 AM

Change 417479 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] ce.MWTransclusionNode: increase invisible selector specificity

https://gerrit.wikimedia.org/r/417479

gerritbot added a project: Patch-For-Review.Mar 9 2018, 1:29 AM
gerritbot added a comment.Mar 9 2018, 9:24 AM

Change 417479 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ce.MWTransclusionNode: increase invisible selector specificity

https://gerrit.wikimedia.org/r/417479

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 9 2018, 10:00 AM
gerritbot added a comment.Mar 9 2018, 10:12 AM

Change 417775 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] ce.MWTransclusionNode: increase invisible selector specificity

https://gerrit.wikimedia.org/r/417775

Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.Mar 9 2018, 10:13 AM
Jdforrester-WMF subscribed.

Made a back-port, but I won't be around to deploy it, sorry.

Pcoombe merged a task: T189399: Visual Editor: displaying templates in Edit mode.Mar 11 2018, 9:14 PM
Pcoombe added a subscriber: Kerry_Raymond.
matmarex merged a task: T189659: A few templates get an odd placemet in VisualEditor.Mar 14 2018, 10:32 AM
matmarex added a subscriber: jeblad.
jeblad added a comment.Mar 14 2018, 10:40 AM

Note that how the mark is handled also blocks editing. I wrote about this in T189659 but it was closed as a duplicate. Blocking editing isn't the same as the mark simply being large.

matmarex subscribed.Mar 14 2018, 10:44 AM

It's just the wrong font size causing it to be overlaid on the text and blocking its editing.

It looks like this:

image.png (326×1 px, 124 KB)

It's supposed to look like this:
image.png (326×1 px, 123 KB)

Just fixing the font size fixes the issue.

DLynch added a comment.Mar 14 2018, 3:19 PM

It's all fixed on beta, we're just awaiting deploy. That back-port James made has languished over the weekend.

image.png (110×565 px, 17 KB)

matmarex added a comment.Mar 14 2018, 4:44 PM

Scheduled: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20180314T1700

matmarex added a comment.Mar 14 2018, 6:00 PM

The SWAT deployment had some problems (the person doing the deploy didn't have time to deploy all of the scheduled patches) and I only noticed that five minutes before the deployment window ended. Let's try again in the next one: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20180314T2300

gerritbot added a comment.Mar 14 2018, 11:19 PM

Change 417775 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] ce.MWTransclusionNode: increase invisible selector specificity

https://gerrit.wikimedia.org/r/417775

Stashbot subscribed.Mar 15 2018, 12:02 AM

Mentioned in SAL (#wikimedia-operations) [2018-03-15T00:02:20Z] <tgr@tin> Synchronized php-1.31.0-wmf.24/extensions/VisualEditor/modules/ve-mw: VE fixes: T189267, T189381 (duration: 01m 16s)

Stashbot mentioned this in T189381: Clear VE autosave when making changes in 2010 editor.Mar 15 2018, 12:02 AM

Mentioned in SAL (#wikimedia-operations) [2018-03-15T00:03:46Z] <tgr@tin> Synchronized php-1.31.0-wmf.25/extensions/VisualEditor/modules/ve-mw: VE fixes: T189267, T189381 (duration: 01m 15s)

matmarex closed this task as Resolved.Mar 15 2018, 12:48 AM
matmarex removed a project: Patch-For-Review.

The fix is live on all Wikimedia wikis now.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 15 2018, 3:00 AM
Liuxinyu970226 unsubscribed.Mar 20 2018, 3:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits