Page MenuHomePhabricator

Error: Deleted row returned in non-changes mode
Closed, ResolvedPublic

Description

Lots of exceptions like this:

Deleted row returned in non-changes mode
srv/mediawiki/php-1.31.0-wmf.24/extensions/ReadingLists/src/Api/ApiQueryReadingListEntries.php:195
#0 /srv/mediawiki/php-1.31.0-wmf.24/extensions/ReadingLists/src/Api/ApiQueryReadingListEntries.php(105): MediaWiki\Extensions\ReadingLists\Api\ApiQueryReadingListEntries->getResultItem(stdClass, string)
#1 /srv/mediawiki/php-1.31.0-wmf.24/extensions/ReadingLists/src/Api/ApiQueryReadingListEntries.php(32): MediaWiki\Extensions\ReadingLists\Api\ApiQueryReadingListEntries->run()
#2 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiQuery.php(249): MediaWiki\Extensions\ReadingLists\Api\ApiQueryReadingListEntries->execute()
#3 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiMain.php(1580): ApiQuery->execute()
#4 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiMain.php(542): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiMain.php(513): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.31.0-wmf.24/api.php(94): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): include(string)
#8 {main}

Event Timeline

Tgr created this task.Mar 9 2018, 12:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2018, 12:42 AM

Change 418152 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Fix deleted row handling in ApiQueryReadingListEntries

https://gerrit.wikimedia.org/r/418152

Change 418152 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix deleted row handling in ApiQueryReadingListEntries

https://gerrit.wikimedia.org/r/418152

Change 418156 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@wmf/1.31.0-wmf.24] Fix deleted row handling in ApiQueryReadingListEntries

https://gerrit.wikimedia.org/r/418156

Tgr updated the task description. (Show Details)Mar 9 2018, 11:16 PM

Change 418156 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@wmf/1.31.0-wmf.24] Fix deleted row handling in ApiQueryReadingListEntries

https://gerrit.wikimedia.org/r/418156

Mentioned in SAL (#wikimedia-operations) [2018-03-09T23:29:04Z] <tgr@tin> Synchronized php-1.31.0-wmf.24/extensions/ReadingLists/src/Api/ApiQueryReadingListEntries.php: T189272 fix stupid ReadingLists typo breaking production (duration: 00m 54s)

Tgr closed this task as Resolved.Mar 9 2018, 11:29 PM
Tgr moved this task from Doing to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
Tgr added a comment.Mar 9 2018, 11:33 PM

Fixed. This broke sync (/changes/since/ endpoint) of lists which contained any deleted item; caused ~2000 errors in the last few days.