Abusefilter did not successfully tag the edits
Closed, ResolvedPublic

Description

All edits triggered Abusefilter didn't tagged by Abusefilter. It looks like it started at 2018/3/8 20:33 (UTC). There are the same bugs in zhwiki, enwiki, zh Beta Cluster.

A2093064 created this task.Mar 9 2018, 1:05 PM
Restricted Application added subscribers: Scoopfinder, Cosine02, Aklapper. · View Herald TranscriptMar 9 2018, 1:05 PM
Daimona triaged this task as Unbreak Now! priority.Mar 9 2018, 2:11 PM
Daimona added a subscriber: Daimona.

I confirm this also happens on it.wiki. Needs to be fixed ASAP since it actually breaks the purpose of any filter tagging edits.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 9 2018, 2:11 PM
Daimona moved this task from Backlog to Internal bugs on the AbuseFilter board.Mar 9 2018, 2:12 PM

Without even looking, I suppose this is due to some change in .24. The change which seems more related to tags is this. Might have broken something?

Change 417912 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Fix typo in wgAbuseFilterActions

https://gerrit.wikimedia.org/r/417912

Huji added a subscriber: Huji.Mar 9 2018, 2:21 PM

That's what I am thinking too. But I had tested it with various values of $wgAbusefilterActions['tag'] and it seemed to work properly in all those cases.

Change 417915 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@wmf/1.31.0-wmf.24] Fix typo in wgAbuseFilterActions

https://gerrit.wikimedia.org/r/417915

Huji added a comment.Mar 9 2018, 2:24 PM

@matej_suchanek good eyes! When testing, I had copied the variable name from the patch, so no wonder it worked.

The bug is also on my local wiki, and indeed the main if branch was false. Luckily Matěj got it quickly.

Needs to be backported as well.

Change 417912 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Fix typo in wgAbuseFilterActions

https://gerrit.wikimedia.org/r/417912

Change 417915 merged by Reedy:
[mediawiki/extensions/AbuseFilter@wmf/1.31.0-wmf.24] Fix typo in wgAbuseFilterActions

https://gerrit.wikimedia.org/r/417915

Mentioned in SAL (#wikimedia-operations) [2018-03-09T18:26:38Z] <reedy@tin> Synchronized php-1.31.0-wmf.24/extensions/AbuseFilter/includes/AbuseFilter.class.php: Unbreak AbuseFilter tagging T189299 (duration: 00m 59s)

Huji closed this task as Resolved.Mar 9 2018, 6:35 PM
Huji removed a project: Patch-For-Review.
Huji claimed this task.
Huji added a subscriber: Reedy.

Special thanks to @Reedy for taking the time to deploy this.