Page MenuHomePhabricator
Create Task
Maniphest T189301

Remove deprecated global function wfRunHooks from extensions and mw-core
Closed, ResolvedPublic
Actions

Description

As per https://gerrit.wikimedia.org/g/mediawiki/core/+/master/docs/hooks.txt

229 Hooks::run() was added in MediaWiki 1.18, before that the global function
230 wfRunHooks must be used, which was deprecated in MediaWiki 1.25.

wfRunHooks has deprecated since MediaWiki 1.25, So removing it from MediaWiki extension and core is good.

Search in gerrit extensions: https://codesearch.wmflabs.org/search/?q=wfRunHooks&i=nope&files=&repos= [Ignore the .patch file]

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jayprakash12345 created this task.Mar 9 2018, 1:56 PM
Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptMar 9 2018, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jayprakash12345 moved this task from Unsorted to Needs removal on the Technical-Debt board.Mar 9 2018, 1:56 PM
gerritbot subscribed.Mar 9 2018, 1:59 PM

Change 417892 had a related patch set (by Jayprakash12345) published:
[mediawiki/skins/p2wiki@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417892

gerritbot added a project: Patch-For-Review.Mar 9 2018, 1:59 PM

Change 417896 had a related patch set (by Jayprakash12345) published:
[mediawiki/skins/Synagonism@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417896

gerritbot added a comment.Mar 9 2018, 2:04 PM

Change 417897 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/BlueSpiceTagCloud@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417897

Jayprakash12345 mentioned this in rEBSG73651150e2ed: Remove deprecated global function wfRunHooks.Mar 9 2018, 2:08 PM
gerritbot added a comment.Mar 9 2018, 2:09 PM

Change 417901 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/EmailAuthorization@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417901

Jayprakash12345 mentioned this in rEEAUadc822cd871d: Remove deprecated global function wfRunHooks.Mar 9 2018, 2:10 PM
Jayprakash12345 removed a project: User-Jayprakash12345.Mar 9 2018, 2:12 PM
Aklapper renamed this task from Remove deprecated global function wfRunHooks from extenions and mw-core to Remove deprecated global function wfRunHooks from extensions and mw-core.Mar 9 2018, 2:20 PM
Aklapper edited projects, added MediaWiki-extensions-General; removed MediaWiki-extensions-Other.
gerritbot added a comment.Mar 9 2018, 2:29 PM

Change 417901 merged by jenkins-bot:
[mediawiki/extensions/EmailAuthorization@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417901

gerritbot added a comment.Mar 9 2018, 2:35 PM

Change 417897 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceTagCloud@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417897

gerritbot added a comment.Mar 9 2018, 2:41 PM

Change 417896 merged by jenkins-bot:
[mediawiki/skins/Synagonism@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417896

gerritbot added a comment.Mar 9 2018, 2:44 PM

Change 417892 merged by jenkins-bot:
[mediawiki/skins/p2wiki@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417892

Umherirrender triaged this task as Medium priority.Mar 9 2018, 2:44 PM
Umherirrender updated the task description. (Show Details)
gerritbot added a comment.Mar 9 2018, 3:26 PM

Change 417938 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417938

gerritbot added a comment.Mar 9 2018, 3:29 PM

Change 417939 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/SemanticInternalObjects@master] Remove deprecated dieUsageMsg methods

https://gerrit.wikimedia.org/r/417939

gerritbot added a comment.Mar 9 2018, 3:30 PM

Change 417941 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/SemanticExpressiveness@master] Remove deprecated dieUsageMsg methods

https://gerrit.wikimedia.org/r/417941

Jayprakash12345 mentioned this in rEBTRce97043558d4: Remove deprecated global function wfRunHooks.Mar 9 2018, 3:32 PM
gerritbot added a comment.Mar 9 2018, 3:33 PM

Change 417942 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Remove wfRunHooks from comment

https://gerrit.wikimedia.org/r/417942

Jayprakash12345 mentioned this in rEBSN96f66ba654f7: Remove wfRunHooks from comment.Mar 9 2018, 3:33 PM
gerritbot added a comment.Mar 9 2018, 3:49 PM

Change 417950 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/SemanticPageSeries@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417950

gerritbot added a comment.Mar 9 2018, 3:52 PM

Change 417954 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/WikEdDiff@master] Remove deprecated global function wfRunHooks from mentions

https://gerrit.wikimedia.org/r/417954

gerritbot added a comment.Mar 9 2018, 3:55 PM

Change 417955 had a related patch set (by Jayprakash12345) published:
[mediawiki/skins/webplatform@master] Remove deprecated global function wfRunHooks from mention

https://gerrit.wikimedia.org/r/417955

gerritbot added a comment.Mar 9 2018, 3:58 PM

Change 417939 merged by jenkins-bot:
[mediawiki/extensions/SemanticInternalObjects@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417939

gerritbot added a comment.Mar 9 2018, 3:59 PM

Change 417956 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/Contest@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417956

gerritbot added a comment.Mar 9 2018, 4:44 PM

Change 417950 merged by jenkins-bot:
[mediawiki/extensions/SemanticPageSeries@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417950

gerritbot added a comment.Mar 9 2018, 4:44 PM

Change 417956 merged by jenkins-bot:
[mediawiki/extensions/Contest@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417956

gerritbot added a comment.Mar 9 2018, 4:52 PM

Change 417941 merged by jenkins-bot:
[mediawiki/extensions/SemanticExpressiveness@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417941

gerritbot added a comment.Mar 9 2018, 4:54 PM

Change 417955 merged by jenkins-bot:
[mediawiki/skins/webplatform@master] Remove deprecated global function wfRunHooks from mention

https://gerrit.wikimedia.org/r/417955

gerritbot added a comment.Mar 9 2018, 4:56 PM

Change 417942 merged by Umherirrender:
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Remove wfRunHooks from comment

https://gerrit.wikimedia.org/r/417942

gerritbot added a comment.Mar 9 2018, 5:02 PM

Change 417938 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417938

gerritbot added a comment.Mar 9 2018, 5:05 PM

Change 417984 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/Translate@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417984

gerritbot added a comment.Mar 9 2018, 5:31 PM

Change 417954 merged by jenkins-bot:
[mediawiki/extensions/WikEdDiff@master] Remove deprecated global function wfRunHooks from mentions

https://gerrit.wikimedia.org/r/417954

Jayprakash12345 mentioned this in rEBSNb321d4af0c82: Final NoteDb migration updates.Jun 8 2018, 11:54 PM
Jayprakash12345 mentioned this in rEBTR6853d915a4c4: Final NoteDb migration updates.Jun 9 2018, 2:32 PM
Jayprakash12345 mentioned this in rEBSGbb08c3afc369: Final NoteDb migration updates.Jun 11 2018, 12:18 AM
Jayprakash12345 mentioned this in rEEAU91659d2275e8: Final NoteDb migration updates.Jun 11 2018, 8:34 PM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:11 PM
Krinkle moved this task from Untriaged to <= 2015 / MW 1.26 on the Technical-Debt (Deprecation process) board.Jul 13 2018, 11:16 PM
xSavitar updated the task description. (Show Details)Oct 6 2018, 10:56 AM
xSavitar removed a project: Patch-For-Review.Nov 5 2018, 10:20 AM
gerritbot added a comment.Nov 5 2018, 10:45 AM

Change 471692 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/ApprovedRevs@master] Removed deprecated global function wfHooksRun()

https://gerrit.wikimedia.org/r/471692

gerritbot added a project: Patch-For-Review.Nov 5 2018, 10:45 AM
gerritbot added a comment.Nov 5 2018, 8:46 PM

Change 471692 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Removed deprecated global function wfHooksRun()

https://gerrit.wikimedia.org/r/471692

gerritbot added a comment.Nov 20 2018, 2:41 PM

Change 417984 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove deprecated global function wfRunHooks

https://gerrit.wikimedia.org/r/417984

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 3:00 PM
Krinkle removed a project: Patch-For-Review.Jan 10 2019, 6:47 PM
Krinkle removed projects: Technical-Debt (Deprecation process), MediaWiki-General.Jan 10 2019, 7:02 PM
Krinkle subscribed.

Looks like this is a tracking task for extensions generally. The core change was already done in 1.32, the function no longer exists in master. Taking it off the deprecation process as such.

gerritbot added a comment.Apr 19 2019, 4:44 PM

Change 505264 had a related patch set uploaded (by Paladox; owner: Alangi Derick):
[mediawiki/extensions/ApprovedRevs@REL1_32] Removed deprecated global function wfHooksRun()

https://gerrit.wikimedia.org/r/505264

gerritbot added a project: Patch-For-Review.Apr 19 2019, 4:44 PM
gerritbot added a comment.Apr 22 2019, 1:07 AM

Change 505264 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@REL1_32] Removed deprecated global function wfHooksRun()

https://gerrit.wikimedia.org/r/505264

Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM
Umherirrender closed this task as Resolved.Jun 7 2019, 8:24 PM
Umherirrender subscribed.

All extensions hosted on gerrit.wikimedia.org are done

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits