CentralNotice geoIP tests may fail, depending on client configuration
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Imarlier
	Mar 9 2018, 7:19 PM

Description

CentralNotice has a couple of tests in its geoIP suite that may fail, dependent on the configuration of the specific MW install where they're being run. This is fragile.

Details

	Subject	Repo	Branch	Lines +/-
	ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic	mediawiki/extensions/CentralNotice	master	+10 -4

Customize query in gerrit

Event Timeline

• Imarlier created this task.Mar 9 2018, 7:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2018, 7:19 PM

Change 418026 had a related patch set uploaded (by Imarlier; owner: Imarlier):
[mediawiki/extensions/CentralNotice@master] ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic

https://gerrit.wikimedia.org/r/418026

gerritbot added a project: Patch-For-Review.Mar 9 2018, 7:20 PM

@Imarlier thanks for this!!!!

AndyRussG added a project: Performance-Team.Mar 9 2018, 8:02 PM

• Imarlier moved this task from Inbox, needs triage to Radar on the Performance-Team board.Mar 12 2018, 5:24 PM

• Imarlier edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle moved this task from Limbo to Perf issue on the Performance-Team (Radar) board.Mar 12 2018, 7:26 PM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Mar 12 2018, 7:35 PM

Change 418026 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] ext.CentralNotice.geoIP.tests: Make sure we don't hit fallback logic

https://gerrit.wikimedia.org/r/418026

• Imarlier closed this task as Resolved.Mar 21 2018, 8:05 PM

CentralNotice geoIP tests may fail, depending on client configurationClosed, ResolvedPublicActions

Description

Details

Event Timeline

CentralNotice geoIP tests may fail, depending on client configuration
Closed, ResolvedPublic
Actions