Page MenuHomePhabricator
Create Task
Maniphest T189331

If deepcat keyword fails with too many categories, empty query is run
Closed, ResolvedPublic
Actions

Description

If deepcat: keyword returns an error and not other query criteria has been provided, the engine runs query that essentially searches for nothing. Instead it should not run anything and return empty result.

If other query criteria has been provided then it may be ok to run the search and provide result, but empty search is always useless.

Details

SubjectRepoBranchLines +/-
Disable results if there are too many categoriesmediawiki/extensions/CirrusSearchmaster+26 -0
Customize query in gerrit

Related Objects

Event Timeline

Smalyshev created this task.Mar 9 2018, 8:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2018, 8:34 PM
Smalyshev mentioned this in T188350: Produce search error if deepcat search returns too many categories.Mar 9 2018, 8:34 PM
Smalyshev moved this task from needs triage to Up Next on the Discovery-Search board.Mar 13 2018, 5:35 PM
Smalyshev moved this task from Up Next to Current work on the Discovery-Search board.
Smalyshev edited projects, added Discovery-Search (Current work); removed Discovery-Search.
Lea_WMDE added a comment.Mar 16 2018, 9:33 AM

Hi @Smalyshev do you have an estimation when this bug will approximately be fixed?

Smalyshev triaged this task as High priority.Mar 16 2018, 5:01 PM
Smalyshev added a project: User-Smalyshev.
Smalyshev moved this task from Backlog to Next on the User-Smalyshev board.
Smalyshev moved this task from Next to Doing on the User-Smalyshev board.Mar 16 2018, 6:47 PM
gerritbot subscribed.Mar 16 2018, 7:23 PM

Change 420113 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/CirrusSearch@master] Disable results if there are too many categories

https://gerrit.wikimedia.org/r/420113

gerritbot added a project: Patch-For-Review.Mar 16 2018, 7:23 PM
Smalyshev moved this task from Doing to In review on the User-Smalyshev board.Mar 16 2018, 7:27 PM
Smalyshev moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Mar 16 2018, 8:00 PM
Smalyshev added a comment.Mar 20 2018, 8:54 PM

@Lea_WMDE to confirm, the fix would be if there are too many categories, the query would fail (return no results at all).

gerritbot added a comment.Mar 20 2018, 9:06 PM

Change 420113 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Disable results if there are too many categories

https://gerrit.wikimedia.org/r/420113

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 20 2018, 10:00 PM
Lea_WMDE added a comment.Mar 21 2018, 10:06 AM

@Smalyshev confirmed! There will be the error message, though, right?

Smalyshev closed this task as Resolved.Mar 21 2018, 4:54 PM
Smalyshev claimed this task.

@Lea_WMDE yes.

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 6 2019, 3:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL