Page MenuHomePhabricator
Create Task
Maniphest T189340

LogicException from line 248 of /srv/mediawiki/php-1.31.0-wmf.24/extensions/ReadingLists/src/ReadingListRepository.php: Encountered deleted list with non-unique name
Closed, ResolvedPublic
Actions

Description

Rare, but happens.

#0 /srv/mediawiki/php-1.31.0-wmf.24/extensions/ReadingLists/src/Api/ApiReadingListsCreate.php(33): MediaWiki\Extensions\ReadingLists\ReadingListRepository->addList(string, string)
#1 /srv/mediawiki/php-1.31.0-wmf.24/extensions/ReadingLists/src/Api/ApiReadingLists.php(46): MediaWiki\Extensions\ReadingLists\Api\ApiReadingListsCreate->execute()
#2 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiMain.php(1580): MediaWiki\Extensions\ReadingLists\Api\ApiReadingLists->execute()
#3 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiMain.php(542): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.31.0-wmf.24/includes/api/ApiMain.php(513): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.31.0-wmf.24/api.php(94): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)
#7 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Log ReadingLists warningsoperations/mediawiki-configmaster+1 -0
Log more information when logic errors happenmediawiki/extensions/ReadingListsmaster+54 -7
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Mar 9 2018, 11:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2018, 11:02 PM
Tgr updated the task description. (Show Details)Mar 9 2018, 11:14 PM
Tgr updated the task description. (Show Details)
Tgr updated the task description. (Show Details)Mar 9 2018, 11:17 PM
gerritbot subscribed.Mar 10 2018, 4:16 AM

Change 418300 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Log more information when logic errors happen

https://gerrit.wikimedia.org/r/418300

gerritbot added a project: Patch-For-Review.Mar 10 2018, 4:16 AM
Tgr moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Mar 10 2018, 4:17 AM
Tgr mentioned this in rERLSe3050854efad: Log more information when logic errors happen.Mar 10 2018, 4:20 AM
gerritbot added a comment.Mar 12 2018, 3:36 PM

Change 418300 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Log more information when logic errors happen

https://gerrit.wikimedia.org/r/418300

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 12 2018, 4:00 PM
Tgr moved this task from Code Review to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Mar 13 2018, 4:33 PM
gerritbot added a comment.Mar 17 2018, 4:59 AM

Change 420155 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[operations/mediawiki-config@master] Log ReadingLists warnings

https://gerrit.wikimedia.org/r/420155

gerritbot added a comment.Mar 19 2018, 11:38 PM

Change 420155 merged by jenkins-bot:
[operations/mediawiki-config@master] Log ReadingLists warnings

https://gerrit.wikimedia.org/r/420155

Tgr added a comment.Mar 21 2018, 4:54 AM
wikiadmin@10.64.32.26(wikishared)>select max(rl_date_updated) from reading_list where rl_deleted = 1 and rl_name not like 'deleted-%';
+----------------------+
| max(rl_date_updated) |
+----------------------+
| 20180305195743       |
+----------------------+
1 row in set (0.00 sec)

wikiadmin@10.64.32.26(wikishared)>select min(rl_date_updated) from reading_list where rl_deleted = 1 and rl_name like 'deleted-%';
+----------------------+
| min(rl_date_updated) |
+----------------------+
| 20180306224200       |
+----------------------+
1 row in set (0.00 sec)

So apparently I forgot to clean up the names of old deleted lists (that were deleted before the patch for T188120 was deployed).

Tgr closed this task as Resolved.Apr 2 2018, 1:39 PM

This only affected lists which have been deleted before March 6 and those have been hard-deleted since (there are two remaining but both are test lists).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits