Page MenuHomePhabricator
Create Task
Maniphest T189369

libraryupdater does not Code-Review+2 some extra library
Closed, ResolvedPublic
Actions

Description

The libraryupdater has a list of extra library to work on.
The php-parrallel-lint was updated on this extra library, but some of them does not get Code-Review+2

It works on mediawiki/tools/*, mediawiki/libs/* and mediawiki/* but fails on:

  • wikimedia/textcat
  • php-session-serializer
  • testing-access-wrapper
  • purtle
  • labs/tools/stewardbots
  • integration/docroot
  • css-sanitizer
  • cdb
  • base-convert
  • at-ease
  • WrappedString
  • RunningStat
  • RelPath
  • IPSet
  • HtmlFormatter
  • CLDRPluralRuleParser
  • AhoCorasick

Please have a look if some rights are missing for the bot. Thanks

Details

ProjectBranchLines +/-Subject
labs/libraryupgradermaster+11 -3Auto +2 in repos outside of mediawiki/
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Mar 10 2018, 11:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2018, 11:34 AM
Umherirrender added a comment.Mar 10 2018, 11:50 AM

If the bot should not merge these repositories, there should be a way to trigger the tests.

By the way, the update was not happen for:

  • utfnormal
  • wikimedia/lucene-explain-parser
  • avro-php (found T177273 for it)
MarcoAurelio added a subscriber: MarcoAurelio.Mar 10 2018, 3:49 PM

As for labs/tools/stewardbots I'd prefer that the bot kept the current behaviour as we have to sync the toolforge repo later and it helps to have this kind of reminder :-)

Legoktm added a subscriber: Legoktm.Mar 10 2018, 7:10 PM

Right now it only auto +2's if the repo starts with mediawiki/ (https://gerrit.wikimedia.org/r/plugins/gitiles/labs/libraryupgrader/+/master/container/thing.py#123)

I think I can have it just try to upload the patch with +2 regardless, (which should fail if it's not in the ACL), and if it fails it can upload it again without the +2.

Umherirrender added a comment.Mar 10 2018, 7:18 PM

I was just wonder about it, having a good reason is also okay for me. Having tests running when not CR+2 would be nice.

Umherirrender mentioned this in rCSSS9a69a85c62a0: Update patch set 1.Jun 9 2018, 5:17 PM
Umherirrender mentioned this in R1907:d397f22fca7a: Update patch set 1.Jun 10 2018, 12:10 PM
gerritbot added a subscriber: gerritbot.Sep 2 2018, 9:38 PM

Change 457107 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/libraryupgrader@master] Auto +2 in repos outside of mediawiki/

https://gerrit.wikimedia.org/r/457107

gerritbot added a project: Patch-For-Review.Sep 2 2018, 9:38 PM
Legoktm mentioned this in rLLUPf50d54420eef: Auto +2 in repos outside of mediawiki/.Sep 2 2018, 9:40 PM
gerritbot added a comment.Sep 2 2018, 9:41 PM

Change 457107 merged by jenkins-bot:
[labs/libraryupgrader@master] Auto +2 in repos outside of mediawiki/

https://gerrit.wikimedia.org/r/457107

Legoktm closed this task as Resolved.Sep 4 2018, 2:31 AM
Legoktm claimed this task.
Legoktm mentioned this in R2145:f50d54420eef: Auto +2 in repos outside of mediawiki/.Oct 20 2019, 6:40 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2019, 7:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL