Page MenuHomePhabricator
Create Task
Maniphest T189371

phan and taint/sec for CentralAuth
Closed, ResolvedPublic
Actions

Description

rECAU extension-CentralAuth could use phan and sec-checks.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CentralAuthmaster+111 -28Add phan
integration/configmaster+1 -0layout: [CentralAuth] Add phan
mediawiki/extensions/CentralAuthmaster+6 -4Minor escaping fixes for phan-taint-check
mediawiki/extensions/CentralAuthmaster+9 -1[WIP] add phan&taint tests for CentralAuth
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarcoAurelio created this task.Mar 10 2018, 12:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2018, 12:32 PM
MarcoAurelio triaged this task as Medium priority.Mar 10 2018, 12:32 PM
MarcoAurelio added a subtask: T189227: taint-checks for CentralAuth failing.
MarcoAurelio updated the task description. (Show Details)Mar 10 2018, 3:46 PM
gerritbot added a subscriber: gerritbot.Mar 11 2018, 11:43 AM

Change 418721 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/CentralAuth@master] [WIP] add phan tests for CentralAuth

https://gerrit.wikimedia.org/r/418721

gerritbot added a project: Patch-For-Review.Mar 11 2018, 11:43 AM
MarcoAurelio added a comment.Mar 11 2018, 12:06 PM

Do I have to add on the 'scripts' section what's being mentioned https://www.mediawiki.org/wiki/Phan-taint-check-plugin as well, or does the 'extra' script the same?

gerritbot added a comment.Mar 12 2018, 2:29 PM

Change 418721 abandoned by MarcoAurelio:
[WIP] add phan&taint tests for CentralAuth

https://gerrit.wikimedia.org/r/418721

MarcoAurelio removed a project: Patch-For-Review.Mar 12 2018, 2:29 PM
gerritbot added a comment.Mar 13 2018, 12:02 PM

Change 419154 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/extensions/CentralAuth@master] Minor escaping fixes for phan-taint-check

https://gerrit.wikimedia.org/r/419154

gerritbot added a project: Patch-For-Review.Mar 13 2018, 12:02 PM
gerritbot added a comment.May 20 2018, 2:54 PM

Change 419154 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Minor escaping fixes for phan-taint-check

https://gerrit.wikimedia.org/r/419154

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 20 2018, 3:00 PM
gerritbot added a comment.Mar 2 2019, 1:51 PM

Change 493806 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/CentralAuth@master] Add phan

https://gerrit.wikimedia.org/r/493806

Daimona claimed this task.Mar 2 2019, 1:51 PM
gerritbot added a comment.Mar 22 2019, 9:44 AM

Change 493806 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/CentralAuth@master] Add phan

https://gerrit.wikimedia.org/r/493806

Umherirrender added a parent task: T224783: Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories.May 31 2019, 9:39 PM
Jdforrester-WMF closed subtask T189227: taint-checks for CentralAuth failing as Resolved.Jul 15 2019, 6:15 PM
gerritbot added a comment.Jul 15 2019, 10:20 PM

Change 523332 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [CentralAuth] Add phan

https://gerrit.wikimedia.org/r/523332

gerritbot added a comment.Jul 15 2019, 10:32 PM

Change 523332 merged by jenkins-bot:
[integration/config@master] layout: [CentralAuth] Add phan

https://gerrit.wikimedia.org/r/523332

Stashbot added a comment.Jul 15 2019, 10:40 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-15T22:40:55Z] <James_F> Zuul: [CentralAuth] Add phan T189371

gerritbot added a comment.Jul 15 2019, 10:55 PM

Change 493806 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add phan

https://gerrit.wikimedia.org/r/493806

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 11:00 PM
Daimona closed this task as Resolved.Jul 16 2019, 11:30 AM
Daimona removed a project: Patch-For-Review.

Phan was added, and taint-check done in the subtask.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL