Page MenuHomePhabricator

As New messages'none' is appearing long in LiquidThreads
Closed, ResolvedPublic

Description

As "New messages none" is appearing long in LiquidThreads


Better to change "New messages none" to "New messages[0]" this decreases the length of the personal tools menu and improves the appearnece.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2018, 12:58 PM
Aklapper renamed this task from Avoid Long New message in LiquidThreads Extension to Avoid long "New message" string (lqt_newmessages) in LiquidThreads.Mar 10 2018, 2:37 PM

Do you have a real example / screenshot when the current message is too long?

Gopavasanth renamed this task from Avoid long "New message" string (lqt_newmessages) in LiquidThreads to As New messages'none' is appearing long in LiquidThreads.Mar 10 2018, 3:58 PM
Gopavasanth updated the task description. (Show Details)
Gopavasanth added a comment.EditedMar 10 2018, 5:02 PM

@Aklapper am I wrong? is my description wrong?

No, I only asked for a specific real-world example when the current situation is a problem.

Changing to "New messages (0)" would be ok. It's arguably more consistent with "New messages (999)" or whatever the number.

Change 418585 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Change in "New message (none)" in LiquidThreads.

https://gerrit.wikimedia.org/r/418585

Gopavasanth closed this task as Resolved.May 8 2018, 12:59 PM
Gopavasanth removed a project: Patch-For-Review.