Page MenuHomePhabricator
Create Task
Maniphest T189372

As New messages'none' is appearing long in LiquidThreads
Closed, ResolvedPublic
Actions

Description

As "New messages none" is appearing long in LiquidThreads

Screenshot from 2018-03-10 18-13-11.png (37×705 px, 5 KB)

Better to change "New messages none" to "New messages[0]" this decreases the length of the personal tools menu and improves the appearnece.
Screenshot from 2018-03-10 21-27-10.png (34×662 px, 5 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/LiquidThreadsmaster+4 -6Change in "New message (none)" in LiquidThreads.
Customize query in gerrit

Event Timeline

Gopavasanth created this task.Mar 10 2018, 12:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2018, 12:58 PM
Aklapper renamed this task from Avoid Long New message in LiquidThreads Extension to Avoid long "New message" string (lqt_newmessages) in LiquidThreads.Mar 10 2018, 2:37 PM

Do you have a real example / screenshot when the current message is too long?

Gopavasanth renamed this task from Avoid long "New message" string (lqt_newmessages) in LiquidThreads to As New messages'none' is appearing long in LiquidThreads.Mar 10 2018, 3:58 PM
Gopavasanth updated the task description. (Show Details)
Gopavasanth added a comment.EditedMar 10 2018, 5:02 PM

@Aklapper am I wrong? is my description wrong?

Aklapper added a comment.Mar 10 2018, 5:12 PM

No, I only asked for a specific real-world example when the current situation is a problem.

Nemo_bis added a subscriber: Nemo_bis.Mar 10 2018, 5:18 PM

Changing to "New messages (0)" would be ok. It's arguably more consistent with "New messages (999)" or whatever the number.

gerritbot added a project: Patch-For-Review.Mar 13 2018, 5:43 PM
Prtksxna added a subscriber: Prtksxna.Mar 23 2018, 11:10 AM
gerritbot added a subscriber: gerritbot.May 8 2018, 12:14 PM

Change 418585 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Change in "New message (none)" in LiquidThreads.

https://gerrit.wikimedia.org/r/418585

Gopavasanth closed this task as Resolved.May 8 2018, 12:59 PM
Gopavasanth removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 8 2018, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL