Page MenuHomePhabricator
Create Task
Maniphest T189375

MediaWiki:Common.css does not allow starting and trailing space inside url()
Closed, ResolvedPublic
Actions

Description

If you add

.badge-recommendedarticle {
	list-style-image: url( "https://upload.wikimedia.org/wikipedia/commons/thumb/c/c7/Rekommenderad_grön.svg/9px-Rekommenderad_grön.svg.png" );
}

to MediaWiki:Common.css, it's turned into

.badge-recommendedarticle {
	list-style-image: url("/w/ \"https://upload.wikimedia.org/wikipedia/commons/thumb/c/c7/Rekommenderad_grön.svg/9px-Rekommenderad_grön.svg.png\"");
}

The starting "/w/" causes this to fail. This seems kinda dangerous, as https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#Whitespace says

One space after a starting and before an ending parentheses (( and )) in selectors (ex. :not()) and properties (ex. rgba()).

ResourceLoader should either be extended to allow leading and trailing spaces, or the style guidelines at mediawiki.org should be revised to no longer recommend this.

Details

SubjectRepoBranchLines +/-
RELEASE-NOTES: Fix typo in CSSMin release notemediawiki/coreREL1_31+1 -1
RELEASE-NOTES: Fix typo in CSSMin release notemediawiki/coremaster+1 -1
CSSMin: Fix breaking of quoted urls with outer spacingmediawiki/coreREL1_31+9 -3
CSSMin: Fix breaking of quoted urls with outer spacingmediawiki/coremaster+7 -2
Customize query in gerrit

Event Timeline

Nirmos created this task.Mar 10 2018, 2:58 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 10 2018, 2:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JohanahoJ subscribed.Mar 10 2018, 4:06 PM
• Imarlier assigned this task to Krinkle.Mar 12 2018, 8:11 PM
• Imarlier moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.
Krinkle triaged this task as High priority.Mar 12 2018, 8:18 PM
Krinkle added a comment.Mar 13 2018, 12:20 AM

I've confirmed that using quotes inside url() with spaces around is valid in CSS and works in Chrome and Firefox.

I've also confirmed the described bug with a failing unit test.

gerritbot subscribed.Mar 13 2018, 12:20 AM

Change 419087 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] CSSMin: Fix breaking of quoted urls with outer spacing

https://gerrit.wikimedia.org/r/419087

gerritbot added a project: Patch-For-Review.Mar 13 2018, 12:20 AM
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.Mar 13 2018, 12:21 AM
Krinkle moved this task from To-do: Goals prioritized current Quarter to Doing (old) on the Performance-Team board.Mar 27 2018, 3:02 AM
Krinkle closed this task as Resolved.Apr 20 2018, 7:11 PM
gerritbot added a comment.Apr 20 2018, 7:24 PM

Change 419087 merged by jenkins-bot:
[mediawiki/core@master] CSSMin: Fix breaking of quoted urls with outer spacing

https://gerrit.wikimedia.org/r/419087

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 20 2018, 8:00 PM
gerritbot added a comment.Apr 23 2018, 4:20 PM

Change 428371 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_31] CSSMin: Fix breaking of quoted urls with outer spacing

https://gerrit.wikimedia.org/r/428371

gerritbot added a comment.Apr 23 2018, 4:51 PM

Change 428371 merged by jenkins-bot:
[mediawiki/core@REL1_31] CSSMin: Fix breaking of quoted urls with outer spacing

https://gerrit.wikimedia.org/r/428371

ReleaseTaggerBot added a project: MW-1.31-release-notes.Apr 23 2018, 5:00 PM
Nirmos added a comment.EditedApr 23 2018, 5:28 PM

I'm a little bit confused here. This bug is about quoted URLs, and that's also what the commit message in https://gerrit.wikimedia.org/r/428371 says. However, RELEASE-NOTES-1.31 says unquoted URLs. Have you actually fixed two different issues here, or is the wording in the release notes a mistake?

Krinkle added a comment.Apr 23 2018, 5:33 PM
In T189375#4150759, @Nirmos wrote:

I'm a little bit confused here. This bug is about quoted URLs, and that's also what the commit message in https://gerrit.wikimedia.org/r/428371 says. However, RELEASE-NOTES-1.31 says unquoted URLs. Have you actually fixed two different issues here, or is the wording the release notes a mistake?

Thanks, you're right. The bug was only with quoted URLs.

The way we fixed this problem was by improving the way we capture unquoted URLs. CSSMin detects unquoted, then single-quoted, then double-quoted. Its detection for unquoted urls looked at url( "something" ) and saw that it was a url( followed by something that is not a single quote or double quote, and thus captured it as an unquoted url (including the space and double-quote symbol as part of the url).

Because the code change only altered logic intended for unquoted urls, it confused me when writing the release notes.

gerritbot added a comment.Apr 23 2018, 5:35 PM

Change 428385 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] RELEASE-NOTES: Fix typo in CSSMin release note

https://gerrit.wikimedia.org/r/428385

gerritbot added a comment.Apr 23 2018, 5:36 PM

Change 428387 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_31] RELEASE-NOTES: Fix typo in CSSMin release note

https://gerrit.wikimedia.org/r/428387

gerritbot added a comment.Apr 23 2018, 5:55 PM

Change 428385 merged by jenkins-bot:
[mediawiki/core@master] RELEASE-NOTES: Fix typo in CSSMin release note

https://gerrit.wikimedia.org/r/428385

gerritbot added a comment.Apr 23 2018, 6:03 PM

Change 428387 merged by jenkins-bot:
[mediawiki/core@REL1_31] RELEASE-NOTES: Fix typo in CSSMin release note

https://gerrit.wikimedia.org/r/428387

JohanahoJ unsubscribed.Jan 10 2019, 2:49 PM
Nirmos added a project: Wikimedia-Minify.Feb 3 2021, 10:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL