Page MenuHomePhabricator
Create Task
Maniphest T189380

Close VE gracefully when the 'Article' tab is clicked, so that changes are not "recovered" when they shouldn't be
Closed, ResolvedPublic
Actions

Description

Provided you are not changing revision, we don't have to fully reload the page, and can use the VE dialog for continue/discard. This has the benefit of discarding auto-saved changes if you hit discard (which we can't do with the system beforeUnload popup).

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Attach deactivate code to namespace tab ('Main'/'Article')Esandersmediawiki/extensions/VisualEditormaster+8 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Mar 10 2018, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2018, 5:49 PM
Esanders mentioned this in T189337: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost!.Mar 10 2018, 5:51 PM
gerritbot subscribed.Mar 10 2018, 7:07 PM

Change 418601 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Attach deactivate code to namespace tab ('Main'/'Article')

https://gerrit.wikimedia.org/r/418601

gerritbot added a project: Patch-For-Review.Mar 10 2018, 7:07 PM
Esanders mentioned this in T57370: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing.Mar 13 2018, 11:29 AM
Esanders mentioned this in T189576: [Epic] Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors).
• Deskana renamed this task from Close VE gracefully when the 'Article' tab is clicked to Close VE gracefully when the 'Article' tab is clicked, so that changes are not "recovered" when they shouldn't be.Mar 13 2018, 11:34 AM
• Deskana assigned this task to Esanders.
• Deskana triaged this task as High priority.
• Deskana added a project: VisualEditor-MediaWiki-2017WikitextEditor.
• Deskana moved this task from To Triage to Current work on the VisualEditor board.
• Deskana edited projects, added: VisualEditor (Current work); removed: VisualEditor.
• Deskana moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Mar 14 2018, 9:19 AM

Change 418601 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Attach deactivate code to namespace tab ('Main'/'Article')

https://gerrit.wikimedia.org/r/418601

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 14 2018, 10:00 AM
• matmarex closed this task as Resolved.Mar 15 2018, 12:57 AM
• matmarex removed a project: Patch-For-Review.
• matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
• Deskana added a parent task: T189576: [Epic] Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors).Mar 15 2018, 5:40 PM
Ryasmeen added a project: Verified.Mar 15 2018, 11:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits