Page MenuHomePhabricator
Create Task
Maniphest T189381

Clear VE autosave when making changes in 2010 editor
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If you switch from VE to 2010WTE mid-edit (or navigate to the 2010 editor in some other way), your auto-saved changes are never discarded, even if you save changes in the 2010 editor.

Details

SubjectRepoBranchLines +/-
Clear VE autosave whenever WikiEditor is loadedmediawiki/extensions/VisualEditormaster+9 -2
Clear auto-save when switching to fallback wikitext editormediawiki/extensions/VisualEditorwmf/1.31.0-wmf.24+7 -0
Clear VE autosave whenever WikiEditor is loadedmediawiki/extensions/VisualEditorwmf/1.31.0-wmf.25+9 -2
Clear auto-save when switching to fallback wikitext editormediawiki/extensions/VisualEditorwmf/1.31.0-wmf.25+7 -0
Clear VE autosave whenever WikiEditor is loadedmediawiki/extensions/VisualEditorwmf/1.31.0-wmf.24+9 -2
Clear auto-save when switching to fallback wikitext editormediawiki/extensions/VisualEditormaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 10 2018, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2018, 5:51 PM
Esanders mentioned this in T189337: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost!.Mar 10 2018, 5:51 PM
gerritbot subscribed.Mar 10 2018, 6:05 PM

Change 418597 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Clear auto-save when switching to fallback wikitext editor

https://gerrit.wikimedia.org/r/418597

gerritbot added a project: Patch-For-Review.Mar 10 2018, 6:05 PM
Esanders triaged this task as High priority.Mar 10 2018, 6:06 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
gerritbot added a comment.Mar 10 2018, 6:31 PM

Change 418599 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Clear VE autosave whenever WikiEditor is loaded

https://gerrit.wikimedia.org/r/418599

• Niharika subscribed.Mar 12 2018, 10:25 PM
DLynch mentioned this in T189254: Regression: Changes made in Wikieditor are lost when switching back to VisualEditor.Mar 13 2018, 5:00 PM
• Deskana moved this task from Incoming to Code review on the VisualEditor (Current work) board.Mar 14 2018, 3:01 PM
• Deskana set the point value for this task to 1.
• Deskana subscribed.

This will need backporting and SWAT deploying, too.

• Deskana mentioned this in T57370: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing.Mar 14 2018, 3:02 PM
• Deskana merged a task: T189254: Regression: Changes made in Wikieditor are lost when switching back to VisualEditor.
• Deskana added subscribers: Raymond, DLynch, TheDJ.
gerritbot added a comment.Mar 14 2018, 5:55 PM

Change 418597 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Clear auto-save when switching to fallback wikitext editor

https://gerrit.wikimedia.org/r/418597

gerritbot added a comment.Mar 14 2018, 6:25 PM

Change 418599 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Clear VE autosave whenever WikiEditor is loaded

https://gerrit.wikimedia.org/r/418599

gerritbot added a comment.Mar 14 2018, 6:47 PM

Change 419501 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] Clear auto-save when switching to fallback wikitext editor

https://gerrit.wikimedia.org/r/419501

gerritbot added a comment.Mar 14 2018, 6:47 PM

Change 419503 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] Clear VE autosave whenever WikiEditor is loaded

https://gerrit.wikimedia.org/r/419503

gerritbot added a comment.Mar 14 2018, 6:47 PM

Change 419504 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.25] Clear auto-save when switching to fallback wikitext editor

https://gerrit.wikimedia.org/r/419504

gerritbot added a comment.Mar 14 2018, 6:47 PM

Change 419505 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.25] Clear VE autosave whenever WikiEditor is loaded

https://gerrit.wikimedia.org/r/419505

matmarex subscribed.Mar 14 2018, 6:51 PM

Scheduled the deployment of backports: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20180314T2300

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 14 2018, 7:00 PM
Esanders claimed this task.Mar 14 2018, 9:42 PM
gerritbot added a comment.Mar 14 2018, 11:28 PM

Change 419503 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] Clear VE autosave whenever WikiEditor is loaded

https://gerrit.wikimedia.org/r/419503

gerritbot added a comment.Mar 14 2018, 11:31 PM

Change 419504 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.25] Clear auto-save when switching to fallback wikitext editor

https://gerrit.wikimedia.org/r/419504

gerritbot added a comment.Mar 14 2018, 11:39 PM

Change 419505 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.25] Clear VE autosave whenever WikiEditor is loaded

https://gerrit.wikimedia.org/r/419505

gerritbot added a comment.Mar 14 2018, 11:39 PM

Change 419501 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.24] Clear auto-save when switching to fallback wikitext editor

https://gerrit.wikimedia.org/r/419501

Stashbot mentioned this in T189267: Invisible templates are unexpectedly large.Mar 15 2018, 12:02 AM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-03-15T00:02:20Z] <tgr@tin> Synchronized php-1.31.0-wmf.24/extensions/VisualEditor/modules/ve-mw: VE fixes: T189267, T189381 (duration: 01m 16s)

Stashbot added a comment.Mar 15 2018, 12:03 AM

Mentioned in SAL (#wikimedia-operations) [2018-03-15T00:03:46Z] <tgr@tin> Synchronized php-1.31.0-wmf.25/extensions/VisualEditor/modules/ve-mw: VE fixes: T189267, T189381 (duration: 01m 15s)

matmarex closed this task as Resolved.Mar 15 2018, 12:57 AM
matmarex removed a project: Patch-For-Review.
matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.

The fixes are live on all Wikimedia wikis now.

If you notice any related issues remaining, please file separate tasks. T189337: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! is the only remaining autosave issue we're still investigating.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)); removed MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 15 2018, 3:00 AM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 15 2018, 4:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL