Page MenuHomePhabricator
Create Task
Maniphest T189502

Only display "Remember selection for future searches" when user is logged in
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Wit the AC from T181638: "Remember selection for future searches" feature for AdvancedSearch, the checkbox for storing the current namespace selection is always present. However, the namespace selection can only be stored when the user is logged in, otherwise, the checkbox will be ignored. This will be confusing for non-logged in users when AdvancedSearch comes out of beta and is available for all users.

Acceptance criteria:

  • The checkbox "Remember selection for future searches" is only shown to non-anonymous users.

Tip for fixing:

Make advancedSearch depend on mw.user and check mw.user.isAnon()

Details

SubjectRepoBranchLines +/-
Adjust check for registered usersmediawiki/extensions/AdvancedSearchmaster+1 -1
Hide "Remember selection" from anon usersmediawiki/extensions/AdvancedSearchmaster+45 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

gabriel-wmde triaged this task as Medium priority.Mar 12 2018, 3:26 PM
gabriel-wmde created this task.
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 12 2018, 3:26 PM
gabriel-wmde changed the point value for this task from 2 to 1.Mar 12 2018, 3:26 PM
gabriel-wmde removed a project: wmde-fundraising-sprint-19.
Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Advanced-Search board.Mar 14 2018, 9:22 AM
Charlie_WMDE moved this task from ToDo to In work by others on the WMDE-Design (WMDE-Design-Workboard Doing) board.Mar 19 2018, 2:30 PM
• Tim_WMDE claimed this task.Jun 1 2018, 3:36 PM
• Tim_WMDE added a project: WMDE-FUN-Sprint-2018-05-28.
• Tim_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.
• Tim_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-05-28 board.
gerritbot subscribed.Jun 4 2018, 1:28 PM

Change 437244 had a related patch set uploaded (by Tim Eulitz; owner: Tim Eulitz):
[mediawiki/extensions/AdvancedSearch@master] Hide "Remember selection" from anon users

https://gerrit.wikimedia.org/r/437244

gerritbot added a project: Patch-For-Review.Jun 4 2018, 1:28 PM
• Tim_WMDE removed • Tim_WMDE as the assignee of this task.Jun 4 2018, 1:30 PM
• Tim_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-05-28 board.
• Tim_WMDE subscribed.
• Tim_WMDE mentioned this in rEASR0a808f8b16b3: Hide "Remember selection" from anon users.Jun 4 2018, 1:32 PM
• Tim_WMDE moved this task from Review to Doing on the WMDE-FUN-Sprint-2018-05-28 board.Jun 5 2018, 8:33 AM
• Tonina_Zhelyazkova_WMDE assigned this task to • Tim_WMDE.Jun 5 2018, 10:24 AM
• Tim_WMDE mentioned this in rEASRd243c91d41ba: Hide "Remember selection" from anon users.Jun 5 2018, 10:35 AM
• Tim_WMDE removed • Tim_WMDE as the assignee of this task.Jun 5 2018, 10:41 AM
• Tim_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-05-28 board.
• Tim_WMDE moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-05-28 board.Jun 5 2018, 12:51 PM
• Tim_WMDE moved this task from Deploy to Test to Review on the WMDE-FUN-Sprint-2018-05-28 board.
gerritbot added a comment.Jun 5 2018, 2:50 PM

Change 437244 merged by Tonina Zhelyazkova:
[mediawiki/extensions/AdvancedSearch@master] Hide "Remember selection" from anon users

https://gerrit.wikimedia.org/r/437244

• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-05-28 board.Jun 5 2018, 2:50 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 5 2018, 3:00 PM
gabriel-wmde moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2018-05-28 board.Jun 7 2018, 9:30 AM
Charlie_WMDE added a subscriber: • Tonina_Zhelyazkova_WMDE.Jun 8 2018, 3:52 PM

@Tonina_Zhelyazkova_WMDE I just realised, I can't really test that because advanced search is a beta feature that only logged in users can use.

Is there a way for me to circumvent it or can I assume that if the old advanced search interface is missing the checkbox then the new one will aswell?

• Tim_WMDE added a comment.Jun 8 2018, 3:54 PM

@Charlie_WMDE No, there is actually no way to currently test this properly. You can assume it works correctly if the previous behavior for logged-in users still functions normally.

Charlie_WMDE moved this task from Test to Done on the WMDE-FUN-Sprint-2018-05-28 board.Jun 8 2018, 3:59 PM
thiemowmde moved this task from Incoming to Advanced Search on the TCB-Team (now WMDE-TechWish) board.Jun 12 2018, 4:06 PM
Lea_WMDE closed this task as Resolved.Oct 11 2018, 8:51 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:47 PM
gerritbot added a comment.May 20 2023, 9:36 AM

Change 921472 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Adjust check for anon users to exclude "named"

https://gerrit.wikimedia.org/r/921472

gerritbot added a comment.May 21 2023, 8:27 AM

Change 921472 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Adjust check for registered users

https://gerrit.wikimedia.org/r/921472

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 21 2023, 9:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL