Page MenuHomePhabricator
Create Task
Maniphest T189517

[Spike 4hrs] Evaluate splitting LESS into separate CSS entries
Closed, DeclinedPublic0 Estimated Story PointsSpike
Actions

Description

Questions to answer

  • Identify pros and cons of generating Webpack CSS entries based on JavaScript CSS imports. Consider writing a prototype patch to help shape this effort.
  • Answer the question: is there _weird_ LESS variable synchronization concerns (tm) with Core? Some of these have been moved into wikimedia-ui-base. How does mediawiki ui fit into this?
  • Do we think there's much risk with LESS compiler or css-janus version mismatches in Core?

Outcome

Please write up your findings on mediawiki.org under Reading/Web/Loading CSS in webpack for mediawiki

Event Timeline

• Niedzielski created this task.Mar 12 2018, 6:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2018, 6:14 PM
Volker_E subscribed.Mar 12 2018, 6:19 PM
Jdlrobson renamed this task from Evaluate splitting LESS into separate CSS entries to [Spike] Evaluate splitting LESS into separate CSS entries.Mar 15 2018, 3:33 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.
ovasileva renamed this task from [Spike] Evaluate splitting LESS into separate CSS entries to [Spike 4hrs] Evaluate splitting LESS into separate CSS entries.Mar 28 2018, 4:17 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.
Jdlrobson set the point value for this task to 0.Mar 28 2018, 4:20 PM
Jdlrobson subscribed.

(to signal we talked about it adding 0 story points)

Jdlrobson added a parent task: T192622: [EPIC] Page previews post-deploy cleanup.Apr 20 2018, 12:50 AM
Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.May 7 2018, 8:11 PM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jun 20 2018, 5:10 PM
Jdlrobson removed a parent task: T192622: [EPIC] Page previews post-deploy cleanup.Jun 27 2018, 11:43 PM
Jdlrobson moved this task from Backlog to Next Up on the Page-Previews board.Jul 25 2018, 8:41 AM
Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Sep 25 2018, 9:17 PM
• Niedzielski added a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).Oct 2 2018, 7:46 PM
• Niedzielski added a subscriber: ovasileva.

@Jdlrobson, @ovasileva, I think we need to work on this spike to know whether or not we should touch the LESS files in MobileFrontend. I propose we bring it onto the board soon.

The layer of indirection provided by Webpack for JavaScript is very useful. It would be excellent to have the same kind of flexibility in our styling code if it doesn't interfere with ResourceLoader. Our way forward with JavaScript is clear: just stick to the existing ResourceLoader module structure. However, we haven't invested much time yet in figuring out how styles play into the investment project. Investigating now seems timely and avoids overlapping work in mobile.startup JavaScript. This work would be independent and no risk given that no code should be merged as part of this spike.

Jdlrobson added a comment.Oct 2 2018, 8:09 PM

Might be worth reflecting on how this went in Popups. To be honest I didn't feel the change in Popups provided many benefits.

Shall we talk about this on Monday? It already looks like a css based agenda!

Jdlrobson moved this task from Next Up to Needs Analysis on the Page-Previews board.Oct 2 2018, 8:09 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Nov 15 2018, 7:01 PM
Jdlrobson moved this task from Backlog to Post-initial migration on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Nov 26 2018, 10:34 PM
Jdlrobson raised the priority of this task from Medium to Needs Triage.Mar 8 2019, 8:03 PM
Jdlrobson moved this task from Post-initial migration to Make Minerva independent of MobileFrontend on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.
Jdlrobson triaged this task as Low priority.Aug 2 2019, 4:57 PM
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptAug 2 2019, 4:57 PM
Jdlrobson moved this task from Make Minerva independent of MobileFrontend to Backlog on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Jan 17 2020, 11:44 PM
Jdlrobson moved this task from Backlog to Componentize MobileFrontend on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.
Jdlrobson moved this task from Componentize MobileFrontend to Review and refactor components on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.
Jdlrobson closed this task as Declined.May 4 2021, 11:18 PM

Not a priority right now. Particularly given the build step discussion for WVUI

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL