Maniphest T189536

Timeline: 'time between' math incorrect
Open, LowPublic
Actions

Assigned To

None

Authored By

	• TBolliger
	Mar 12 2018, 10:41 PM

Tags

Referenced Files

None

Subscribers

Description

Says 2 days when it should sat 12 hours: https://tools.wmflabs.org/interaction-timeline/?wiki=dewiki&user=Flo%20Sorg&user=Hajo-Muc&startDate=1509577200&endDate=1520809200

the last edits on the bottom of this example

Event Timeline

• TBolliger created this task.Mar 12 2018, 10:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2018, 10:41 PM

• SPoore subscribed.Mar 13 2018, 8:41 PM

• Niharika moved this task from Defects to Prioritized on the InteractionTimeline board.Aug 2 2019, 4:48 AM

• Niharika added a project: Anti-Harassment.Aug 6 2019, 5:38 PM

• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Aug 8 2019, 5:24 AM

The example is incorrect because the time difference is ~36 hours and not 12. Moment rounds that up to 2 days.

@Niharika How important do you think it is to fix this?

There's a discussion around a feature request for this in moment.js, including some workarounds here. I'm not sure how practical a workaround would be, given the need for internationalization (e.g. some particular breakdown of days/hours that is more readable in English may not be in every language).

If we think the rounding is confusing, could we just change the string to: "Around {duration} between edits" (as opposed to: "{duration} between edits")?

@Tchanders I don't think this one is very important. Sorry, I just saw your comment. I like your suggestion about changing the wording. We could hold off on this for now though.