Page MenuHomePhabricator

Add column sorting to event and program lists
Closed, ResolvedPublic2 Estimated Story Points

Description

It might be helpful to be able to sort the columns when you have a lot of programs/events, for example https://tools.wmflabs.org/grantmetrics/programs/WikiDonne_roadmap

Event Timeline

I was bold and just did this. Hope that's OK! :) I did the same for Pageviews Analysis and XTools, so the code was mostly a copy/paste. I think sorting is super useful and an expected feature.

The event show page does not have column sorting, as our decision at T188770#4044891 might conflict with it. My thoughts are to allow you to hover over the label to get the tooltip, and when this happens the infoicon changes to a sorting icon. That way it's clear it changes the sorting when clicked, maybe? Now that I think of it, we should probably show these tooltips on the other pages, too, so the same problem will persist there.

And another thing, what should the default sorting be, for instance at https://tools.wmflabs.org/grantmetrics/programs/WikiDonne_roadmap? Event name?

I was bold and just did this. Hope that's OK! :) I did the same for Pageviews Analysis and XTools, so the code was mostly a copy/paste. I think sorting is super useful and an expected feature.

Looks pretty good to me! I think it'll be quite useful.

The event show page does not have column sorting, as our decision at T188770#4044891 might conflict with it. My thoughts are to allow you to hover over the label to get the tooltip, and when this happens the infoicon changes to a sorting icon. That way it's clear it changes the sorting when clicked, maybe? Now that I think of it, we should probably show these tooltips on the other pages, too, so the same problem will persist there.

I replied in that ticket. I don't think it's necessary to show the tooltips everywhere because once the user gets a hang of what the definitions are, they are likely to not want to see the definition again. So let's keep the tooltips just on the event page. And we can show the sorting icons always, not just on hover. I prefer the smaller icons for sorting, like we have on wiki pages. Can we use those?

And another thing, what should the default sorting be, for instance at https://tools.wmflabs.org/grantmetrics/programs/WikiDonne_roadmap? Event name?

Hmm, ideally the event that was created last would show on top by default. What say?

Niharika set the point value for this task to 2.Mar 13 2018, 9:04 PM

Sounds good! I've just updated the sorting icons. The up/down arrows don't vertically center when active, but I think it still looks good. Let me know what you think :)

Also programs and events are now sorted by ID, descending, equivalent to creation date.

Love it! This look great!